-
Task
-
Resolution: Done
-
L3 - Default
-
None
-
S
Context:
In our coding conventions (https://confluence.camunda.com/display/CO/Coding+Conventions), we specify the following:
"If possible, mapping methods to convert between RestDtos and the default Service Layer DTOs are to be implemented on the RestDto as static methods."
Currently, there are still a few mapping methods that aren't implemented on the RestDto as static methods. Lets do a refactor here to align the code with our conventions.
Hint:
This applies to *RestDto, *RequestDto, and *ResponseDto, and should cover mapping both to and from service layer Dtos.
AT:
- Where possible, mappers are moved to their respective RestDtos as static methods
This is the controller panel for Smart Panels app
[OPT-4201] Clean up rest dto mapping to adhere to coding conventions
| Description |
Original:
*Context:*
In our [coding conventions|[https://confluence.camunda.com/display/CO/Coding+Conventions]], we specify the following: "If possible, mapping methods to convert between RestDtos and the default Service Layer DTOs are to be implemented on the RestDto as static methods." Currently, there are still a few mapping methods that aren't implemented on the RestDto as static methods. Lets do a refactor here to align the code with our conventions. *AT:* * Where possible, mappers are moved to their respective RestDtos as static methods |
New:
*Context:*
In our coding conventions ([https://confluence.camunda.com/display/CO/Coding+Conventions)|https://confluence.camunda.com/display/CO/Coding+Conventions], we specify the following: "If possible, mapping methods to convert between RestDtos and the default Service Layer DTOs are to be implemented on the RestDto as static methods." Currently, there are still a few mapping methods that aren't implemented on the RestDto as static methods. Lets do a refactor here to align the code with our conventions. *AT:* * Where possible, mappers are moved to their respective RestDtos as static methods |
| Mentioned Roles |
| Mentioned Groups |
| Remote Link | New: This issue links to "Page (camunda confluence)" [ 14964 ] |
| Description |
Original:
*Context:*
In our coding conventions ([https://confluence.camunda.com/display/CO/Coding+Conventions)|https://confluence.camunda.com/display/CO/Coding+Conventions], we specify the following: "If possible, mapping methods to convert between RestDtos and the default Service Layer DTOs are to be implemented on the RestDto as static methods." Currently, there are still a few mapping methods that aren't implemented on the RestDto as static methods. Lets do a refactor here to align the code with our conventions. *AT:* * Where possible, mappers are moved to their respective RestDtos as static methods |
New:
*Context:*
In our coding conventions ([https://confluence.camunda.com/display/CO/Coding+Conventions)|https://confluence.camunda.com/display/CO/Coding+Conventions], we specify the following: "If possible, mapping methods to convert between RestDtos and the default Service Layer DTOs are to be implemented on the RestDto as static methods." Currently, there are still a few mapping methods that aren't implemented on the RestDto as static methods. Lets do a refactor here to align the code with our conventions. *Hint:* This applies to *RestDto, *RequestDto, and *ResponseDto, and should cover mapping both to and from service layer Dtos. *AT:* * Where possible, mappers are moved to their respective RestDtos as static methods |
| Mentioned Roles |
| Mentioned Groups |
| Assignee | New: Andromachi Rozaki [ andromachi.rozaki ] |
| Labels | New: nice_to_have potential_for_3.3 potential_for_next_quarter |