-
Task
-
Resolution: Fixed
-
L3 - Default
-
None
-
Not defined
Context:
Currently the value parsing of KPI reports in DigestService.getKpiValueString is not nullsafe and can lead to NPEs if for some reason the value is null.
Also, there is an incorrect error log for nonexisting reports in getKpiSummaryDtos.
AT:
- incorrect error log is removed
- getKpiValueString is made nullsafe
Testing notes:
Unfortunately the NPE cannot be tested as the issue doesn't seem to be reproduceable.
The incorrect log can be tested: set up a digest, wait for it to be sent out and confirm that there is no log that claims that a report for a digest could not be found.
This is also backported to 39 and 310 maintenance branches
This is the controller panel for Smart Panels app
[OPT-7045] Make KPI value parsing nullsafe
| Status | Original: Triage [ 10612 ] | New: Ready [ 10005 ] |
| Description |
Original:
Context:
Currently the value parsing of KPI reports in DigestService.getKpiValueString is not nullsafe and can lead to NPEs if for some reason the value is null. Also, there is an incorrect error log for nonexisting reports in getKpiSummaryDtos. AT: * incorrect error log is removed * getKpiValueString is made nullsafe |
New:
*Context:*
Currently the value parsing of KPI reports in DigestService.getKpiValueString is not nullsafe and can lead to NPEs if for some reason the value is null. Also, there is an incorrect error log for nonexisting reports in getKpiSummaryDtos. *AT:* * incorrect error log is removed * getKpiValueString is made nullsafe *Testing notes:* Unfortunately the NPE cannot be tested as the issue doesn't seem to be reproduceable. The incorrect log can be tested: set up a digest, wait for it to be sent out and confirm that there is no log that claims that a report for a digest could not be found. |
| Assignee | Original: Helene Waechtler [ helene.waechtler ] | New: Giuliano Rodrigues Lima [ giuliano.rodrigues-lima ] |
| Status | Original: Ready [ 10005 ] | New: In Review [ 10212 ] |
| Labels | New: SUPPORT |
| Assignee | Original: Giuliano Rodrigues Lima [ giuliano.rodrigues-lima ] | New: Helene Waechtler [ helene.waechtler ] |
| Status | Original: In Review [ 10212 ] | New: Rework [ 11413 ] |
| Status | Original: Rework [ 11413 ] | New: Ready for Testing [ 10008 ] |
| Assignee | Original: Helene Waechtler [ helene.waechtler ] | New: Cigdem Ilhan [ cigdem.ilhan ] |
| Status | Original: Ready for Testing [ 10008 ] | New: In Test [ 10004 ] |
| Description |
Original:
*Context:*
Currently the value parsing of KPI reports in DigestService.getKpiValueString is not nullsafe and can lead to NPEs if for some reason the value is null. Also, there is an incorrect error log for nonexisting reports in getKpiSummaryDtos. *AT:* * incorrect error log is removed * getKpiValueString is made nullsafe *Testing notes:* Unfortunately the NPE cannot be tested as the issue doesn't seem to be reproduceable. The incorrect log can be tested: set up a digest, wait for it to be sent out and confirm that there is no log that claims that a report for a digest could not be found. |
New:
*Context:*
Currently the value parsing of KPI reports in DigestService.getKpiValueString is not nullsafe and can lead to NPEs if for some reason the value is null. Also, there is an incorrect error log for nonexisting reports in getKpiSummaryDtos. *AT:* * incorrect error log is removed * getKpiValueString is made nullsafe *Testing notes:* Unfortunately the NPE cannot be tested as the issue doesn't seem to be reproduceable. The incorrect log can be tested: set up a digest, wait for it to be sent out and confirm that there is no log that claims that a report for a digest could not be found. This is also backported to 39 and 310 maintenance branches |