Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-10115

Improve tests for IdentityService#checkPasswordAgainstPolicy

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.11.0, 7.11.0-alpha4
    • None
    • engine
    • None

      Problem
      DefaultPasswordPolicyTest is hard to understand because everything is tested in a single test case.

      Solution
      There exists for each case a dedicated test with a meaningful method name:

      • default policy contains five rules with respective keys and values of parameters
      • valid password
      • length rule violated
      • lower case rule violated
      • upper case rule violated
      • digit rule violated
      • special char rule violated

        This is the controller panel for Smart Panels app

            [CAM-10115] Improve tests for IdentityService#checkPasswordAgainstPolicy

            Tassilo Weidner created issue -
            Tassilo Weidner made changes -
            Description New: *Problem*
            {{DefaultPasswordPolicyTest}} is hard to understand

            *Solution*
            There exists for each case a dedicated test with a meaningful method name:
            * default policy contains five rules with respective keys and values of parameters
            * valid password
            * length rule violated
            * lower case rule violated
            * upper case rule violated
            * digit rule violated
            * special char rule violated
            Tassilo Weidner made changes -
            Link New: This issue depends on CAM-10114 [ CAM-10114 ]
            Tassilo Weidner made changes -
            Description Original: *Problem*
            {{DefaultPasswordPolicyTest}} is hard to understand

            *Solution*
            There exists for each case a dedicated test with a meaningful method name:
            * default policy contains five rules with respective keys and values of parameters
            * valid password
            * length rule violated
            * lower case rule violated
            * upper case rule violated
            * digit rule violated
            * special char rule violated
            New: *Problem*
            {{DefaultPasswordPolicyTest}} is hard to understand because everything is tested in a single test case.

            *Solution*
            There exists for each case a dedicated test with a meaningful method name:
            * default policy contains five rules with respective keys and values of parameters
            * valid password
            * length rule violated
            * lower case rule violated
            * upper case rule violated
            * digit rule violated
            * special char rule violated
            Tassilo Weidner made changes -
            Assignee Original: Tassilo Weidner [ tassilo.weidner ] New: Miklas Boskamp [ miklas.boskamp ]
            Tassilo Weidner made changes -
            Link New: This issue is related to CAM-9929 [ CAM-9929 ]
            Miklas Boskamp made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            Miklas Boskamp made changes -
            Assignee Original: Miklas Boskamp [ miklas.boskamp ] New: Tassilo Weidner [ tassilo.weidner ]
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            Remaining Estimate New: 0 minutes [ 0 ]
            Original Estimate New: 0 minutes [ 0 ]
            Tassilo Weidner made changes -
            Rank New: Ranked higher
            Tassilo Weidner made changes -
            Rank New: Ranked higher

              Unassigned Unassigned
              tassilo.weidner Tassilo Weidner
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: