Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-13509

Consolidate duplicated code for definition removal from deployment cache

    • Icon: Task Task
    • Resolution: Won't Fix
    • Icon: L3 - Default L3 - Default
    • None
    • 7.15.0
    • engine
    • None

      What is the problem?

      The DeploymentCache.removeDeployment method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/deploy/cache/DeploymentCache.java#L310-L319) performs the same functionality as part of the DeploymentManager.deleteDeployment method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/DeploymentManager.java#L126-L129).

      AC:
      Reduce code duplication for the following features:

      • Remove definitions from CmmnModelInstanceCache by deployment id;
      • Remove definitions from DmnModelInstanceCache by deployment id;
      • Remove DecisionRequirementsDefinitions for a deployment;

      Hints (optional):
      The duplication was reported in CAM-13205 and PR 1365.

        This is the controller panel for Smart Panels app

            [CAM-13509] Consolidate duplicated code for definition removal from deployment cache

            Nikola Koevski created issue -
            Nikola Koevski made changes -
            Link New: This issue is related to CAM-13205 [ CAM-13205 ]
            Nikola Koevski made changes -
            Description Original: What is the problem?

            The {{DeploymentCache.removeDeployment}} method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/deploy/cache/DeploymentCache.java#L310-L319) performs the same functionality as part of the {{DeploymentManager.deleteDeployment}} method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/DeploymentManager.java#L126-L129).

            *AC:*
            Reduce code replication.

            Hints (optional):
            The duplication was reported in CAM-13205 and [PR 1365|https://github.com/camunda/camunda-bpm-platform/pull/1365].
            New: What is the problem?

            The {{DeploymentCache.removeDeployment}} method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/deploy/cache/DeploymentCache.java#L310-L319) performs the same functionality as part of the {{DeploymentManager.deleteDeployment}} method (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/DeploymentManager.java#L126-L129).

            *AC:*
            Reduce code duplication for the following features:
            * Remove definitions from {{CmmnModelInstanceCache}} by deployment id;
            * Remove definitions from {{DmnModelInstanceCache}} by deployment id;
            * Remove DecisionRequirementsDefinitions for a deployment;

            Hints (optional):
            The duplication was reported in CAM-13205 and [PR 1365|https://github.com/camunda/camunda-bpm-platform/pull/1365].
            Nikola Koevski made changes -
            Mentioned Roles
            Nikola Koevski made changes -
            Mentioned Groups
            Nikola Koevski made changes -
            Summary Original: Refactor DeploymentCache deployment removal code New: Refactor DeploymentCache definition removal code
            Nikola Koevski made changes -
            Status Original: Open [ 1 ] New: Ready [ 10005 ]
            Nikola Koevski made changes -
            Assignee New: Thorben Lindhauer [ thorben.lindhauer ]
            Thorben Lindhauer made changes -
            Assignee Original: Thorben Lindhauer [ thorben.lindhauer ] New: Tobias Metzke-Bernstein [ tobias.metzke ]
            Tobias Metzke-Bernstein made changes -
            Summary Original: Refactor DeploymentCache definition removal code New: Remove duplicated definition removal code from DeploymentCache

              Unassigned Unassigned
              nikola.koevski Nikola Koevski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: