Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-14784

Allow overwriting beans in CamundaBpmAutoConfiguration

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Unresolved
    • Icon: L3 - Default L3 - Default
    • None
    • 7.17.0
    • spring-boot
    • None

      User Story (Required on creation):

      Hi,

      The following issue is about a code part in the Camunda Spring Boot Starter.

      We are using custom ApplicationEvent in our application to control certain lifecycle aspects during the startup. This means also that we have some subsequent migrations regarding Camunda. This migration is executed after a certain event has been published. Unfortunately, Camunda already starts on the ApplicationReadyEvent (as can be seen in the ProcessApplicationEventPublisher), which is too early for us. In order to give developers more control, it would be sufficient if one could at least overwrite the beans in the CamundaBpmAutoConfiguration without using something like the spring.main.allow-bean-definition-overriding-Setting.

      It would thus be very useful if the beans in the CamundaBpmAutoConfiguration  would be marked with ConditionalOnMissingBean. This would allow easy and clean "overring" of the beans in question with custom logic.

      Functional Requirements (Required before implementation):

      Technical Requirements (Required before implementation):

      Limitations of Scope (Optional):

      Hints (optional):

        This is the controller panel for Smart Panels app

            [CAM-14784] Allow overwriting beans in CamundaBpmAutoConfiguration

            Nils Christian Ehmke created issue -
            Nikola Koevski made changes -
            Assignee New: Nikola Koevski [ nikola.koevski ]

            Nikola Koevski added a comment -

            Hi nils-christian.ehmke,

            Thank you for raising this feature request.

            • I think the request is related to the Camunda Spring Boot Starter, but it would be better if you could explicitly state this in the ticket description.
            • It would also be good if you could provide an example project where you demonstrate how you are currently solving this issue.

            Best,
            Nikola

            Nikola Koevski added a comment - Hi nils-christian.ehmke , Thank you for raising this feature request. I think the request is related to the Camunda Spring Boot Starter, but it would be better if you could explicitly state this in the ticket description. It would also be good if you could provide an example project where you demonstrate how you are currently solving this issue. Best, Nikola
            Nils Christian Ehmke made changes -
            Description Original: h3. User Story (Required on creation):

            Hi,

            We are using custom _ApplicationEvent_ in our application to control certain lifecycle aspects during the startup. This means also that we have some subsequent migrations regarding Camunda. This migration is executed after a certain event has been published. Unfortunately, Camunda already starts on the _ApplicationReadyEvent_ (as can be seen in the {_}ProcessApplicationEventPublisher{_}), which is too early for us. In order to give developers more control, it would be sufficient if one could at least overwrite the beans in the _CamundaBpmAutoConfiguration_ without using something like the {_}spring.main.allow-bean-definition-overriding{_}-Setting.

            It would thus be very useful if the beans in the _CamundaBpmAutoConfiguration_  would be marked with {_}ConditionalOnMissingBean{_}. This would allow easy and clean "overring" of the beans in question with custom logic.
            h3. Functional Requirements (Required before implementation):
            h3. Technical Requirements (Required before implementation):
            h3. Limitations of Scope (Optional):
            h3. Hints (optional):             		New: h3. User Story (Required on creation):

            Hi,

            The following issue is about a code part in the Camunda Spring Boot Starter.

            We are using custom _ApplicationEvent_ in our application to control certain lifecycle aspects during the startup. This means also that we have some subsequent migrations regarding Camunda. This migration is executed after a certain event has been published. Unfortunately, Camunda already starts on the _ApplicationReadyEvent_ (as can be seen in the {_}ProcessApplicationEventPublisher{_}), which is too early for us. In order to give developers more control, it would be sufficient if one could at least overwrite the beans in the _CamundaBpmAutoConfiguration_ without using something like the {_}spring.main.allow-bean-definition-overriding{_}-Setting.

            It would thus be very useful if the beans in the _CamundaBpmAutoConfiguration_  would be marked with {_}ConditionalOnMissingBean{_}. This would allow easy and clean "overring" of the beans in question with custom logic.
            h3. Functional Requirements (Required before implementation):
            h3. Technical Requirements (Required before implementation):
            h3. Limitations of Scope (Optional):
            h3. Hints (optional):

            Nils Christian Ehmke added a comment - - edited

            Hi Nikola,

            I modified the description accordingly.

            I also created a demo application for the issue: https://github.com/nils-christian/CAM-14784. Our only possibility (without the mentioned allow-bean-override-property) at the moment is to disable the Camunda auto configuration completely and replace it with a customized version.

            Best regards

              Nils

            Nils Christian Ehmke added a comment - - edited Hi Nikola, I modified the description accordingly. I also created a demo application for the issue: https://github.com/nils-christian/CAM-14784 . Our only possibility (without the mentioned allow-bean-override-property) at the moment is to disable the Camunda auto configuration completely and replace it with a customized version. Best regards   Nils

            Nikola Koevski added a comment -

            Hi nils-christian.ehmke,

            Thank you for the explanation and the example project. This seems like a valid feature request to me. I'll forward it for a decision and possible scheduling.

            However, this ticket might not be scheduled due to a lack of development time. So I would encourage you to make a code contribution by submitting a pull request.

            Best,
            Nikola

            Nikola Koevski added a comment - Hi nils-christian.ehmke , Thank you for the explanation and the example project. This seems like a valid feature request to me. I'll forward it for a decision and possible scheduling. However, this ticket might not be scheduled due to a lack of development time. So I would encourage you to make a code contribution by submitting a pull request. Best, Nikola
            Nikola Koevski made changes -
            Status Original: Open [ 1 ] New: Ready [ 10005 ]
            Nikola Koevski made changes -
            Assignee Original: Nikola Koevski [ nikola.koevski ] New: Tobias Metzke-Bernstein [ tobias.metzke ]

            Tobias Metzke-Bernstein added a comment -

            Hi nils-christian.ehmke,

            thanks for this proposal, I agree with Nikola here that this makes total sense in the scope of the product and would be a nice enhancement of the Starter.

            We will move this to our backlog and consider it in the next planning sessions. That being said, we cannot yet say if we will work on this in the near future.
            If you want to speed up the process, feel free to make a contribution.

            We'll update the ticket with any related progress and decisions.

            Best,
            Tobias

            Tobias Metzke-Bernstein added a comment - Hi nils-christian.ehmke , thanks for this proposal, I agree with Nikola here that this makes total sense in the scope of the product and would be a nice enhancement of the Starter. We will move this to our backlog and consider it in the next planning sessions. That being said, we cannot yet say if we will work on this in the near future. If you want to speed up the process, feel free to make a contribution. We'll update the ticket with any related progress and decisions. Best, Tobias
            Tobias Metzke-Bernstein made changes -
            Assignee Original: Tobias Metzke-Bernstein [ tobias.metzke ]

              Unassigned Unassigned
              nils-christian.ehmke Nils Christian Ehmke
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: