Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-2716

Composite History Event Handler

XMLWordPrintable

      AT:

      • provide a default implementation of a composite history event handler such that users can more easily add multiple history event handler implementations to the engine

        This is the controller panel for Smart Panels app

            [CAM-2716] Composite History Event Handler

            Alexander Tyatenkov added a comment -

            Hello,

            Can I also try to implement this ticket?

            For example, I could implement 2 composite classes CompositeHistoryEventHandler and CompositeDbHistoryEventHandler inside the package org.camunda.bpm.engine.impl.history.handler.
            Where:

            • CompositeHistoryEventHandler is the simple composite class implemented HistoryEventHandler interface
            • CompositeDbHistoryEventHandler extends CompositeHistoryEventHandler adding the new instance of DbHistoryEventHandler into the inner Collection/List

            Br,
            Alexander

            Alexander Tyatenkov added a comment - Hello, Can I also try to implement this ticket? For example, I could implement 2 composite classes CompositeHistoryEventHandler and CompositeDbHistoryEventHandler inside the package org.camunda.bpm.engine.impl.history.handler . Where: CompositeHistoryEventHandler is the simple composite class implemented HistoryEventHandler interface CompositeDbHistoryEventHandler extends CompositeHistoryEventHandler adding the new instance of DbHistoryEventHandler into the inner Collection/List Br, Alexander

            Thorben Lindhauer added a comment -

            Sure, feel free to provide a pull request.

            Cheers,
            Thorben

            Thorben Lindhauer added a comment - Sure, feel free to provide a pull request. Cheers, Thorben

            Alexander Tyatenkov added a comment - - edited

            Thanks,

            I will try to write unit tests, if it is possible and they are needed for this task, and then create the pull request.
            Anyway writing tests should help me better to learn Camunda, you have plenty of examples.

            Br,
            Alexander

            Alexander Tyatenkov added a comment - - edited Thanks, I will try to write unit tests, if it is possible and they are needed for this task, and then create the pull request. Anyway writing tests should help me better to learn Camunda, you have plenty of examples. Br, Alexander

            Thorben Lindhauer added a comment -

            Yes, please write tests. Feel free to ask if you need assistance.

            Cheers,
            Thorben

            Thorben Lindhauer added a comment - Yes, please write tests. Feel free to ask if you need assistance. Cheers, Thorben

            Thorben Lindhauer added a comment -

            Hi Alexander,

            Thanks for the pull request (for reference: https://github.com/camunda/camunda-bpm-platform/pull/156/). We'll review it in the next days.

            Cheers,
            Thorben

            Thorben Lindhauer added a comment - Hi Alexander, Thanks for the pull request (for reference: https://github.com/camunda/camunda-bpm-platform/pull/156/ ). We'll review it in the next days. Cheers, Thorben

            Thorben Lindhauer added a comment -

            There are issues with the tests for this feature due to which database connection are kept open, at least on oracle. See https://hq2.camunda.com/jenkins/ci/job/7.4-engine-UNIT-oracle-10/25/consoleFull

            We (successfully?) fixed the connection leak issue on postgres with this commit: https://github.com/camunda/camunda-bpm-platform/commit/b80004bbb2b15d0d6adb5daa9788b5bac17e90e1

            Thorben Lindhauer added a comment - There are issues with the tests for this feature due to which database connection are kept open, at least on oracle. See https://hq2.camunda.com/jenkins/ci/job/7.4-engine-UNIT-oracle-10/25/consoleFull We (successfully?) fixed the connection leak issue on postgres with this commit: https://github.com/camunda/camunda-bpm-platform/commit/b80004bbb2b15d0d6adb5daa9788b5bac17e90e1

            Alexander Tyatenkov added a comment -

            Hi, just in case, as I understand I can't help with this.
            And just for myself, I've checked code and can't find something special except of closing all connections in PooledDataSource by invoking close() method on processEngine, as you did in mentioned commit.
            Br,
            Alexander

            Alexander Tyatenkov added a comment - Hi, just in case, as I understand I can't help with this. And just for myself, I've checked code and can't find something special except of closing all connections in PooledDataSource by invoking close() method on processEngine, as you did in mentioned commit. Br, Alexander

            Sebastian Menski added a comment -

            Hi thorben.lindhauer,

            I refactor the test cases to use the cached engine by saving the original history event handler. If that is okay for you close the ticket. Thanks.

            Cheers,
            Sebastian

            Sebastian Menski added a comment - Hi thorben.lindhauer , I refactor the test cases to use the cached engine by saving the original history event handler. If that is okay for you close the ticket. Thanks. Cheers, Sebastian

              Unassigned Unassigned
              thorben.lindhauer Thorben Lindhauer
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: