Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1102

Disable EndEvent and Gateway if no process definition is selected

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 2.0.0
    • None
    • frontend
    • None

      AT:

      • In the branch analysis, as long as no process definition is selected, the two elements EndEvent and Gateway are disabled
      • If I select a process definition and then unselect it, the two elements are again disabled

        This is the controller panel for Smart Panels app

            [OPT-1102] Disable EndEvent and Gateway if no process definition is selected

            Sebastian Stamm added a comment -
            • I would call the variable something like disableFlowNodeSelection instead of disabled, as the render function contains multiple elements that potentially could be disabled, but the variable only affect some of them
            • I think the procDefIsNotSelected function should check the existence of a processDefinitionName and processDefinitionVersion instead of the xml
            • Might be a matter of taste, but I find positive method names easier to read, so I would rename procDefIsNotSelected to isProcDefSelected and have the negation when assigning the return value of the function to the disabled variable

            Sebastian Stamm added a comment - I would call the variable something like disableFlowNodeSelection instead of disabled , as the render function contains multiple elements that potentially could be disabled, but the variable only affect some of them I think the procDefIsNotSelected function should check the existence of a processDefinitionName and processDefinitionVersion instead of the xml Might be a matter of taste, but I find positive method names easier to read, so I would rename procDefIsNotSelected to isProcDefSelected and have the negation when assigning the return value of the function to the disabled variable

            Sebastian Stamm added a comment -
            • I think it is more understandable if isProcDefSelected checks if processDefinitionKey and processDefinitionVersion is set instead of using double negation

            Sebastian Stamm added a comment - I think it is more understandable if isProcDefSelected checks if processDefinitionKey and processDefinitionVersion is set instead of using double negation

              Unassigned Unassigned
              johannes.heinemann Johannes
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: