L3 - Default Reproduce:
- In Internet Explorer 11:
- Create the following Report: View Average Flow Node Duration grouped by Flownodes Visualized as Heatmap
Expected:
- I can see the average flow node duration by flow nodes as heatmap
Observed:
- Every Flow node has maximum heat
This is the controller panel for Smart Panels app
[OPT-1126] IE11: Heatmap too hot
johannes.heinemann: What kind of comment would you like there? It should be clear from the context that this is a polyfill for Number.EPSILON, just like the other polyfills in that file.
sebastian.stamm: Maybe it's because I'm an unexperienced javascript programmer, but when I just have a look at the code, I wouldn't understand why we need the polyfill. Therefore, I would add a comment that we added the polyfill, because otherwise the heatmap does not work in IE11. If we remove IE11 support or heatmaps from our project, we know that we can also remove this polyfill.
I am still not convinced. That we need this to support Internet Explorer applies to every single statement of this file. I would also not reference the heatmap there, as Number.EPSILON has nothing to do with Heatmaps beside that we use it there. Otherwise one might argue that we need a comment for the arrayIncludesShim, as it also does not exist in IE and we use it in the Filter (and EntityList and ReportView and ReportLabelMap and ...)
Works like a charm, but I would like to have a comment there, because otherwise it's not clear why we are doing this. You can close the ticket, when you added the comment.