• Icon: Feature Part Feature Part
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 2.0.0
    • None
    • backend
    • None

      AT:

      • via websockets I can send a request to optimize status and get information the following information as the reponse:
        • the import progress for all engines
        • the connection status for each engine
        • the elasticsearch connection status
      • get update periodically based on configuration

        This is the controller panel for Smart Panels app

            [OPT-1130] I can request the import progress + connection status for all engines at once

            Johannes added a comment -

            Nice, I'm glad that you could finish that so fast

            Review hints:

            • in the ticket it states that you retrieve the import progress for each engine. However, that's actually not the case, because we get only the overall import progress. Please adjust the ticket description and create a new ticket to implement that the import progress reports the progress for each engine.
            • This endpoint is not secured, is it? That's not crucial for the status, but I just want to keep that in mind if we want to add more websocket endpoints.
            • we should document the endpoint somewhere, so other (front-end) developers can get some information about it. Especially, if Sebastian wants to implement the websockets in the front-end, he needs to know the endpoint and what kind of data to expect. I would suggest to have another wiki article next to the rest api documentation.
            • StatusWebSocketIT: I don't like the sleep statement in the test. That makes it very prone to errors. Maybe we can rearrange the test a bit. Let's discuss this.

            Johannes added a comment - Nice, I'm glad that you could finish that so fast Review hints: in the ticket it states that you retrieve the import progress for each engine. However, that's actually not the case, because we get only the overall import progress. Please adjust the ticket description and create a new ticket to implement that the import progress reports the progress for each engine. This endpoint is not secured, is it? That's not crucial for the status, but I just want to keep that in mind if we want to add more websocket endpoints. we should document the endpoint somewhere, so other (front-end) developers can get some information about it. Especially, if Sebastian wants to implement the websockets in the front-end, he needs to know the endpoint and what kind of data to expect. I would suggest to have another wiki article next to the rest api documentation. StatusWebSocketIT: I don't like the sleep statement in the test. That makes it very prone to errors. Maybe we can rearrange the test a bit. Let's discuss this.

            Askar added a comment - - edited

            https://github.com/camunda/camunda-optimize/wiki/WebSockets-API-documentation

            WS is not secured, if we want that I could create a ticket

            Askar added a comment - - edited https://github.com/camunda/camunda-optimize/wiki/WebSockets-API-documentation WS is not secured, if we want that I could create a ticket

              Unassigned Unassigned
              johannes.heinemann Johannes
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: