Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1141

I can set a unit for time number reports in the alert modal

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 2.0.0
    • None
    • frontend
    • None

      As a user, I can define a number report on average process instance duration and when I create an alert with a certain boundary value for that report, I can also choose set units (seconds, minutes, hours, days, weeks, months, years) for the boundary value.

      AT:

      • I define a number report on average process instance duration then in the alert modal:
        • I can select the defined number report
        • the value input field is extended by a unit dropdown menu, where I can choose from seconds, minutes, hours, days, weeks, months, years
        • by default the unit option is set to days
      • I define a number report on count process instance duration frequency then in the alert modal:
      • there is only the value input field without a unit dropdown

        This is the controller panel for Smart Panels app

            [OPT-1141] I can set a unit for time number reports in the alert modal

            Johannes added a comment -

            Review hints:

            • bug: if I choose an average process instance duration number report and the input field is empty and I change the unit, an error is thrown.
            • bug: if I choose an average duration instance number report and choose a value with unit and then change to a count process instance frequency count report, the input field has the value [object Object]
            • In general the code looks good. Still I don't like statements like reportType === 'duration' cluttering up the code. I think there should be a way to circumvent this. Let's discuss it.

            Johannes added a comment - Review hints: bug: if I choose an average process instance duration number report and the input field is empty and I change the unit, an error is thrown. bug: if I choose an average duration instance number report and choose a value with unit and then change to a count process instance frequency count report, the input field has the value [object Object] In general the code looks good. Still I don't like statements like reportType === 'duration' cluttering up the code. I think there should be a way to circumvent this. Let's discuss it.

            Sebastian Stamm added a comment -

            The comparison to the reportType is done whenever the Threshold object needs to be converted into a different format (initial opening, changing report and saving alert). I don't think there is much we can do without making some major changes.

            The other hints have been handled in b18d792

            Sebastian Stamm added a comment - The comparison to the reportType is done whenever the Threshold object needs to be converted into a different format (initial opening, changing report and saving alert). I don't think there is much we can do without making some major changes. The other hints have been handled in b18d792

              Unassigned Unassigned
              johannes.heinemann Johannes
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: