Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-2066 Retierate Command class hierarchy
  3. OPT-2774

Cleanup unused remnants of the command class hierarchy refactoring

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Fixed
    • L3 - Default
    • 2.7.0
    • None
    • backend
    • None

    Description

      AT:

      • the duplicated code in GroupByCandidateGroup and GroupByAssignee classes is merged
      • the command sorting functionality is moved to the CompositeCommandResult class
      • the duplicated code in ProcessGroupByVariable and AbstractDecisionGroupByVariable is merged
      • the GroupByDateVariableIntervalSelection utility class is being removed as well

      Context:
      To make the refactoring easier parts of the code have been duplicated. Since this ticket represents the clean up, the code duplication should now be merged.

      Sebastian Bathke:
      as the CompositeCommandResult is created by the groupByPart.retrieveQueryResult already do you think it would make sense to forward that information (numeric or not) from there into the composite result so it could be picked up from there as an property of the CompositeCommandResult?
      actually couldn't the sorting already be done completely inside retrieveQueryResult on the CompositeCommandResult? as all the stuff related to sorting originates from the groupByPart anyway and then the ReportResultDto doesn't even need sorting functionality it will be just a plain POJO?

      mgm-controller-panel

        This is the controller panel for Smart Panels app

        Attachments

          Activity

            People

              Unassigned Unassigned
              johannes.heinemann Johannes
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Salesforce