-
Type:
Task
-
Resolution: Fixed
-
Priority:
L3 - Default
-
Affects Version/s: None
-
Component/s: backend
-
None
-
170
When we migrated the ES type to use the default value, the source type remained as the index name to allow for the reindexing to work during the migration. In future, the source will always be the default value so this can be replaced in that step. See here for context: https://github.com/camunda/camunda-optimize/pull/1130#discussion_r336556295
There are also some if guards in the ES client that retains types as well as adding the default value. This type retention (for example on SearchRequests) can be removed after this migration. The callers should also stop setting types in the first place as the client will override its value.
AT:
- UpdateIndexStep always uses the default ES type as its source type during upgrades
- The types are set universally in the ES Client and the adjustor, plus any tests that verify working migrations
- The upgrade tests remove the custom schema setup methods that facilitated the migration