• Type: Feature Request
• Resolution: Fixed
• Priority: L3 - Default
• Fix Version/s: 1.0.0
• Affects Version/s: None
• Component/s: frontend
• Labels:

  None

This is the controller panel for Smart Panels app

[OPT-397] add connection indicators to footer

Collapse comment: Sebastian Stamm added a comment - 16/May/17 4:57 PM

Sebastian Stamm added a comment - 16/May/17 4:57 PM

• Should we have tests for the Icon widget?
• We could think about removing the glyphicon- prefix from the icon property as all icons are glyphicons anyway
• We should use the isTruthy utility from the view-utils instead of using state => state in the Indicator component

I am not a fan of having two icons to indicate the connection status. To me this seems like a technical detail we could hide from the business user. My proposal would be to have only one icon. Something like "Status: " or "Status: ". The info what is broken can be included in the tooltip.

Expand comment: Sebastian Stamm added a comment - 16/May/17 4:57 PM

Sebastian Stamm added a comment - 16/May/17 4:57 PM Should we have tests for the Icon widget? We could think about removing the glyphicon- prefix from the icon property as all icons are glyphicons anyway We should use the isTruthy utility from the view-utils instead of using state => state in the Indicator component I am not a fan of having two icons to indicate the connection status. To me this seems like a technical detail we could hide from the business user. My proposal would be to have only one icon. Something like "Status: " or "Status: ". The info what is broken can be included in the tooltip.

Collapse comment: Mariusz added a comment - 17/May/17 7:32 AM, Edited by Mariusz - 17/May/17 10:04 AM

Mariusz added a comment - 17/May/17 7:32 AM - edited

sebastian.stamm

• Icon widgets doesn't have any logic really. It is just something that generates static html. So we could test that, but what is the point?
• Yeah, that makes sense and with it some tests would make sense actually
• Hm... We could do that, although this information is hidden from business user anyway, because that is displayed only during import (something configured and monitored by tech stuff I guess). Although it makes sense to have one icon anyway.

Expand comment: Mariusz added a comment - 17/May/17 7:32 AM, Edited by Mariusz - 17/May/17 10:04 AM

Mariusz added a comment - 17/May/17 7:32 AM - edited sebastian.stamm Icon widgets doesn't have any logic really. It is just something that generates static html. So we could test that, but what is the point? Yeah, that makes sense and with it some tests would make sense actually Hm... We could do that, although this information is hidden from business user anyway, because that is displayed only during import (something configured and monitored by tech stuff I guess). Although it makes sense to have one icon anyway.

Collapse comment: Sebastian Stamm added a comment - 17/May/17 9:52 AM

Sebastian Stamm added a comment - 17/May/17 9:52 AM

Regarding tests for the icon widget: It isn't really super critical. One thing we could test is, that it correctly sets the class-name on the element.

Expand comment: Sebastian Stamm added a comment - 17/May/17 9:52 AM

Sebastian Stamm added a comment - 17/May/17 9:52 AM Regarding tests for the icon widget: It isn't really super critical. One thing we could test is, that it correctly sets the class-name on the element.

Collapse comment: Michael Schoettes added a comment - 30/May/17 2:29 PM

Michael Schoettes added a comment - 30/May/17 2:29 PM

mariusz.sielski, according to the issue description the footer bar in optimize should contain something like

{
  "connectedToEngine" : true,
  "connectedToElasticsearch" : true
}

I guess this indicator shows up during data import only, correct?

Expand comment: Michael Schoettes added a comment - 30/May/17 2:29 PM

Michael Schoettes added a comment - 30/May/17 2:29 PM mariusz.sielski , according to the issue description the footer bar in optimize should contain something like { "connectedToEngine" : true , "connectedToElasticsearch" : true } I guess this indicator shows up during data import only, correct?