Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-4332

Investigate how we can enforce codebase rules

XMLWordPrintable

    • 3
    • S

      We recently discovered an issue with our flexible use of contructors and builders with and without Lombok. We should investigate how we can prevent running into this problem, possibly by having a convention of not using Lombok builders, or alternatively through some kind of custom codebase rule. The shared services team use https://github.com/TNG/ArchUnit, so we should investigate whether this would suit our purpose. Some ideas for rules include:

      • Does controller call any reader/writer directly?
      • Can we validate against misuse of Constructor/Builder?
      • rest DTOs only exist in Rest layers
      • That usages of Mockserver are always verified
      • That we use LocalDateUtil over OffsetDateTime.now()
      • That we don't use lombok builders on DTOs

      ATs:

      • Codebase rules are either enforced through code conventions or some other means
      • We determine whether we can make use of ArchUnit

        This is the controller panel for Smart Panels app

              Unassigned Unassigned
              joshua.windels Joshua Windels
              Andromachi Rozaki Andromachi Rozaki
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: