• Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 3.4.0
    • None
    • frontend
    • None
    • Not defined

      AT:

      • It is possible to select a group of external events and added as a source to the table
      • events with no group will appear as a separate option (ungrouped events) that can be selected
      • there is a dedicated option to select all events whether they are grouped or not
      • all events option cannot exist along with any other group as a source (We should NOT allow a user to select both ‘all’ and a single group of external events)
      • The external event group selection is not displayed in auto generation and pressing the add button will add all the external events

        This is the controller panel for Smart Panels app

            [OPT-4553] add external events group selection list to the add source modal

            Asia Malina added a comment - - edited

            Design Review. 

            • Adding all events can be selected at any time. If an individual group is already selected this will be folded into the all events group. - No grey number of selected items appeaars next to input field in this case.
            •Background blue in a selected item, only appears where the selection was explicitly made in that interaction.

            ie. Not for previously selected items or for selections as part of the select all. 

            • Modal button is disabled if no selection is available 

            • Options cannot be removed from the modal, removal must occur via the pills in the table (and display the warning modal if mapping has occurred. 

            See Prototype 

            Asia Malina added a comment - - edited Design Review.  • Adding all events can be selected at any time. If an individual group is already selected this will be folded into the all events group. - No grey number of selected items appeaars next to input field in this case. •Background blue in a selected item, only appears where the selection was explicitly made in that interaction. ie. Not for previously selected items or for selections as part of the select all.  • Modal button is disabled if no selection is available  • Options cannot be removed from the modal, removal must occur via the pills in the table (and display the warning modal if mapping has occurred.  See Prototype 

            Code looks fine. asia.malina, please check if the behavior of the "All events in a single group" option is what is expected. Right now, if the option was added; when the modal is opened again, it is possible to deselect it and select a single option, which might be inconsistent with the behavior that single groups cannot be deselected in the modal.

            Sebastian Stamm added a comment - Code looks fine. asia.malina , please check if the behavior of the "All events in a single group" option is what is expected. Right now, if the option was added; when the modal is opened again, it is possible to deselect it and select a single option, which might be inconsistent with the behavior that single groups cannot be deselected in the modal.

            Asia Malina added a comment - - edited

            Design review:

            1. Update text for all events selection to...
            'Combine all events in a single group'

            2.As per Stammies comment about the all events behaviour. We had hoped to retain any created mappings. But in the current framework, this creates confusing behaviour. 
            We will remove the ability to safely break up a combined events group to keep consistency of behaviour in the selectable items. 
            Behaviour: Items cannot be deselected from the 'add events' modal. 

            Thanks all! 

            Asia Malina added a comment - - edited Design review: 1. Update text for all events selection to... 'Combine all events in a single group' 2.As per Stammies comment about the all events behaviour. We had hoped to retain any created mappings. But in the current framework, this creates confusing behaviour.  We will remove the ability to safely break up a combined events group to keep consistency of behaviour in the selectable items.  Behaviour: Items cannot be deselected from the 'add events' modal.  Thanks all! 

              Unassigned Unassigned
              omran.abazeed Omran Abazeed
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: