Context:

We recently encountered an issue when the 3.4 -> 3.5 upgrade was attempted to be run on Optimize 3.5. This is because when the upgradePlan is built, we currently do a check for incomplete userTasks. This check was added under the assumption that the upgrade would only ever be built for a 3.4 schema, so it depends on old index structure from 3.4.

However, currently we only check the schema version before running the upgrade (in UpgradeProcedure.performUpgrade), not before building the upgrade plan. To avoid issues like this in the future, we could do this version check earlier and skip building the upgradeplan if the schemaVersion is already at the targetVersion.

AT:

• The upgradePlan should not be created if the schema is already up to date with the targetVersion