We couldn't load all Actvitity tabs. Refresh the page to try again.
If the problem persists, contact your Jira admin.
Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-5442

Adjust ModelElementFilterQueryUtil instanceMatching and to not double nest filters

    • 3
    • S

      Context:

      See comment in PR description: https://github.com/camunda/camunda-optimize/pull/3732#issue-695066628 

      Now that we have quite a few Flownode viewLevel filters that need instance matching, we should adjust the instance and flownode filter methods in ModelElementFilterQueryUtil to ideally have a very similar structure so it's easier to read. Also, adjust `add..Filter` methods to not "double nest" the filters (see explanation in PR) if possible (though we should make sure to double check if this kind of nesting has a reason).

      AT:

      • ModelElementFilterQueryUtil is easier to read, especially addInstanceFilterForRelevantViewLevelFilters

        This is the controller panel for Smart Panels app

            Loading...
            Uploaded image for project: 'Camunda Optimize'
            1. Camunda Optimize
            2. OPT-5442

            Adjust ModelElementFilterQueryUtil instanceMatching and to not double nest filters

              • 3
              • S

                Context:

                See comment in PR description: https://github.com/camunda/camunda-optimize/pull/3732#issue-695066628 

                Now that we have quite a few Flownode viewLevel filters that need instance matching, we should adjust the instance and flownode filter methods in ModelElementFilterQueryUtil to ideally have a very similar structure so it's easier to read. Also, adjust `add..Filter` methods to not "double nest" the filters (see explanation in PR) if possible (though we should make sure to double check if this kind of nesting has a reason).

                AT:

                • ModelElementFilterQueryUtil is easier to read, especially addInstanceFilterForRelevantViewLevelFilters

                  This is the controller panel for Smart Panels app

                        Unassigned Unassigned
                        helene.waechtler Helene Waechtler
                        Votes:
                        0 Vote for this issue
                        Watchers:
                        2 Start watching this issue

                          Created:
                          Updated:

                              Unassigned Unassigned
                              helene.waechtler Helene Waechtler
                              Votes:
                              0 Vote for this issue
                              Watchers:
                              2 Start watching this issue

                                Created:
                                Updated: