Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-6961

Add finally callback to the error handling high order component

XMLWordPrintable

    • Not defined

      Context:
      Sometimes, we need to clean up after an API call. The current implementation of the error handling component does not easily allow that because we have to currently do this in the success call and the failure callback as well. See discussion here

      AT:

      • Add a callback to that is invoked after an API call regardless of whether it failed or not
      • Use the new callback where necessary to eliminate code redundancy.

        This is the controller panel for Smart Panels app

            [OPT-6961] Add finally callback to the error handling high order component

            Omran Abazeed created issue -
            Omran Abazeed made changes -
            Labels New: maintenance
            Omran Abazeed made changes -
            Description Original: *Context:*
            Sometimes, we need to clean up after an API call. The current implementation of the error handling component does not easily allow that because we have to currently do this in the success call and the failure callback as well.

            *AT:*
            * Add a callback to that is invoked after an API call regardless of whether it failed or not
            * Use the new callback where necessary to eliminate code redundancy.
            		New: *Context:*
            Sometimes, we need to clean up after an API call. The current implementation of the error handling component does not easily allow that because we have to currently do this in the success call and the failure callback as well. See discussion here

            *AT:*
             * Add a callback to that is invoked after an API call regardless of whether it failed or not
             * Use the new callback where necessary to eliminate code redundancy.
            Omran Abazeed made changes -
            Description Original: *Context:*
            Sometimes, we need to clean up after an API call. The current implementation of the error handling component does not easily allow that because we have to currently do this in the success call and the failure callback as well. See discussion here

            *AT:*
             * Add a callback to that is invoked after an API call regardless of whether it failed or not
             * Use the new callback where necessary to eliminate code redundancy.             		New: *Context:*
            Sometimes, we need to clean up after an API call. The current implementation of the error handling component does not easily allow that because we have to currently do this in the success call and the failure callback as well. See discussion [here|https://github.com/camunda/camunda-optimize/pull/6669#discussion_r1188257370]

            *AT:*
             * Add a callback to that is invoked after an API call regardless of whether it failed or not
             * Use the new callback where necessary to eliminate code redundancy.
            Joshua Windels made changes -
            Status Original: Triage [ 10612 ] New: Backlog [ 11212 ]
            Michal Konopski made changes -
            Status Original: Backlog [ 11212 ] New: In Development [ 10312 ]
            Omran Abazeed made changes -
            Assignee New: Michal Konopski [ michal.konopski ]
            Michal Konopski made changes -
            Assignee Original: Michal Konopski [ michal.konopski ] New: Omran Abazeed [ omran.abazeed ]
            Status Original: In Development [ 10312 ] New: In Review [ 10212 ]
            Omran Abazeed made changes -
            Assignee Original: Omran Abazeed [ omran.abazeed ] New: Michal Konopski [ michal.konopski ]
            Status Original: In Review [ 10212 ] New: Rework [ 11413 ]
            Michal Konopski made changes -
            Assignee Original: Michal Konopski [ michal.konopski ]
            Resolution New: Done [ 10000 ]
            Status Original: Rework [ 11413 ] New: Done [ 10010 ]
            Giuliano Rodrigues Lima made changes -
            Fix Version/s New: 3.11.0-alpha2 [ 18191 ]

              Unassigned Unassigned
              omran.abazeed Omran Abazeed
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: