Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-10848

Helper mehod "job(activity)" not working when there are multiple jobs

XMLWordPrintable

    • Icon: Bug Report Bug Report
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • assert-8.0.0
    • None
    • assert
    • None

      Created on behalf of the following issue:
      https://github.com/camunda/camunda-bpm-assert/issues/120

      Original description:
      "I have a process waiting at an intermediate message catch event, while at the same time there is a timer event subprocess. When I call BpmnAwareTests.job(activityIfOfTheMessageCatchEvent) it throws "Query return 2 results instead of max 1" because the JobQuery in ProcessInstanceAssert.java:630 finds both jobs, the message and the timer.

      I think it would be better to call the JobQuery not with the executionId, but with the activityId."

        This is the controller panel for Smart Panels app

          1. ProcessInstanceAssert-jobTimerMessage.bpmn
            5 kB
          2. TestError.bpmn
            4 kB

            [CAM-10848] Helper mehod "job(activity)" not working when there are multiple jobs

            Tobias Metzke-Bernstein added a comment -

            I created a minimal test case working with the model ProcessInstanceAssert-jobTimerMessage.bpmn which works absolutely fine with 2 existing job instances:

            @Test
@Deployment(resources = "bpmn/ProcessInstanceAssert-jobTimerMessage.bpmn")
public void testJob_MultipleTimerAndMessage() {
  ProcessInstance instance = runtimeService().startProcessInstanceByKey("process");
  assertThat(instance).isActive();
  assertThat(jobQuery().count()).isEqualTo(2L);
  assertThat(ProcessEngineTests.job("catchIt")).hasActivityId("catchIt");
}

            Tobias Metzke-Bernstein added a comment - I created a minimal test case working with the model ProcessInstanceAssert-jobTimerMessage.bpmn which works absolutely fine with 2 existing job instances: @Test @Deployment(resources = "bpmn/ProcessInstanceAssert-jobTimerMessage.bpmn" ) public void testJob_MultipleTimerAndMessage() { ProcessInstance instance = runtimeService().startProcessInstanceByKey( "process" ); assertThat(instance).isActive(); assertThat(jobQuery().count()).isEqualTo(2L); assertThat(ProcessEngineTests.job( "catchIt" )).hasActivityId( "catchIt" ); }

            Tobias Metzke-Bernstein added a comment -

            Closing this due to inactivity, feel free to reopen.

            Tobias Metzke-Bernstein added a comment - Closing this due to inactivity, feel free to reopen.

            Harry Braun added a comment - - edited

            We have the same problem.
            As soon as there is a subprocess with a timer start event in a process, job() will find two instead of one process. 

            A sample process is included as an attachment.

            @Test
@Deployment(resources = {"processes/TestError.bpmn"})
public void testHappyPath() { 
  ProcessInstance processInstance = runtimeService().startProcessInstanceByKey("Process_Test");   
  assertThat(processInstance).hasPassed("StartEvent_1");   
  execute(ProcessEngineTests.job("Task_Test")); // Error: Query return 2 results instead of max 1 ...??   // execute(job()); // Error: Query return 2 results instead of max 1 ...??   
  assertThat(processInstance).hasPassed("Task_Test"); 
}

            What would be the right way to test this process?

            (Environment: Assert 7.0.0, Camunda 7.13.3-ee, SpringBoot, JDK 11)

            Harry Braun added a comment - - edited We have the same problem. As soon as there is a subprocess with a timer start event in a process, job() will find two instead of one process.  A sample process is included as an attachment. @Test @Deployment(resources = { "processes/TestError.bpmn" }) public void testHappyPath() { ProcessInstance processInstance = runtimeService().startProcessInstanceByKey( "Process_Test" );   assertThat(processInstance).hasPassed( "StartEvent_1" );   execute(ProcessEngineTests.job( "Task_Test" )); // Error: Query return 2 results instead of max 1 ...??   // execute(job()); // Error: Query return 2 results instead of max 1 ...??   assertThat(processInstance).hasPassed( "Task_Test" ); } What would be the right way to test this process? (Environment: Assert 7.0.0, Camunda 7.13.3-ee, SpringBoot, JDK 11)

            Alexander Petioky added a comment -

            can you reopen this task or shall we open a new one?

            Alexander Petioky added a comment - can you reopen this task or shall we open a new one?

            Tobias Metzke-Bernstein added a comment -

            Hey,

            I have reopened this and will investigate within the next 7 working days.
            If this is a more pressing concern, please feel free to open a Support ticket if you are an enterprise customer.

            Best,
            Tobias

            Tobias Metzke-Bernstein added a comment - Hey, I have reopened this and will investigate within the next 7 working days. If this is a more pressing concern, please feel free to open a Support ticket if you are an enterprise customer. Best, Tobias

            Tobias Metzke-Bernstein added a comment -

            Hey,

            thanks for your patience on this.

            I can confirm that this is a bug as there might be multiple jobs at process instance level that will be identified by the execution id used in https://github.com/camunda/camunda-bpm-assert/blob/9f03d14299875b5bf68b44a03e9dc447ddd509c6/core/src/main/java/org/camunda/bpm/engine/test/assertions/bpmn/ProcessInstanceAssert.java#L668.

            As a workaround, you could also use 

              execute(job(jobQuery().activityId("Task_Test")));

            This should just work as expected than.

            Thanks again for providing the example.
            We will take this into our backlog and fix as soon as possible.

            Best,
            Tobias

            Tobias Metzke-Bernstein added a comment - Hey, thanks for your patience on this. I can confirm that this is a bug as there might be multiple jobs at process instance level that will be identified by the execution id used in https://github.com/camunda/camunda-bpm-assert/blob/9f03d14299875b5bf68b44a03e9dc447ddd509c6/core/src/main/java/org/camunda/bpm/engine/test/assertions/bpmn/ProcessInstanceAssert.java#L668 . As a workaround, you could also use execute(job(jobQuery().activityId( "Task_Test" ))); This should just work as expected than. Thanks again for providing the example. We will take this into our backlog and fix as soon as possible. Best, Tobias

              Unassigned Unassigned
              tobias.metzke Tobias Metzke-Bernstein
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: