Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-11166

add TaskListener#timeout to spring eventing

    • Icon: Feature Request Feature Request
    • Resolution: Won't Fix
    • Icon: L3 - Default L3 - Default
    • None
    • None
    • spring-boot
    • None

      I noticed that the timeout event is not propgated via spring eventing in 3.4.0

        This is the controller panel for Smart Panels app

            [CAM-11166] add TaskListener#timeout to spring eventing

            Hi jan.galinski@holisticon.de,

            thanks for opening this feature request. I will discuss it with the development team and once we made a decision on whether we consider it worth implementing I will come back to you.

            Would you be interested in providing a pull request?

            Best,
            Miklas

            Miklas Boskamp added a comment - Hi jan.galinski@holisticon.de , thanks for opening this feature request. I will discuss it with the development team and once we made a decision on whether we consider it worth implementing I will come back to you. Would you be interested in providing a pull request? Best, Miklas

            Jan Galinski added a comment -

            I suppose its just adding the TIMEOUT event name to the list of task events, so yes, I can PR that.

             

            I think it's consistency ... we introduced the spring event listening with the feature "you get notified for all events" ... but now "timeout" and "update" are introduced but just "update" can be handled using spring eventing ... 

            You could also call that a bug ... maybe a test should fail when a new eventName is introduced that is not properly handled in spring boot?

             

            Jan

            Jan Galinski added a comment - I suppose its just adding the TIMEOUT event name to the list of task events, so yes, I can PR that.   I think it's consistency ... we introduced the spring event listening with the feature "you get notified for all events" ... but now "timeout" and "update" are introduced but just "update" can be handled using spring eventing ...  You could also call that a bug ... maybe a test should fail when a new eventName is introduced that is not properly handled in spring boot?   Jan

            Hi Jan,

            I think timeout is a bit different to the other events. The other events are propagated to Spring eventing regardless if there are actual listeners defined in the model. This is not possible for timeouts, so we could only propagate an event if there is already a listener for it. I wonder if this is understandable for users. Part of the problem is that the timeout listener and its trigger are now defined as a single thing in the model, i.e. I cannot define the timeout trigger without creating a corresponding task listener. What is your view on this?

            Cheers,
            Thorben

            Thorben Lindhauer added a comment - Hi Jan, I think timeout is a bit different to the other events. The other events are propagated to Spring eventing regardless if there are actual listeners defined in the model. This is not possible for timeouts, so we could only propagate an event if there is already a listener for it. I wonder if this is understandable for users. Part of the problem is that the timeout listener and its trigger are now defined as a single thing in the model, i.e. I cannot define the timeout trigger without creating a corresponding task listener. What is your view on this? Cheers, Thorben

            We are closing this ticket as part of our backlog grooming. Reasons:

            • We did not receive sufficient evidence that this ticket is important

            Thorben Lindhauer added a comment - We are closing this ticket as part of our backlog grooming. Reasons: We did not receive sufficient evidence that this ticket is important

              Unassigned Unassigned
              jan.galinski@holisticon.de Jan Galinski
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: