Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-12228

Create modifier for ProcessEngineConfigurationImpl.authorizationService

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.14.0, 7.14.0-alpha2
    • None
    • engine
    • None

      AT

      Add setter for the authorizationService configuration property in the ProcessEngineConfigurationImpl class

      Reasoning

      In a plugin I've created, in its 'postInit' method, I'd like to change the value of the field 'authorizationService' of the engine configuration. The method gets passed a parameter of type 'ProcessEngineConfigurationImpl'.

      However, this class has only a getter for the field 'authorizationService', there is no setter. The field itself is declared as 'protected'. As the result, I have to use Java reflection to set the field value which is not very nice.

      It would be helpful if there was a setter for the field 'authorizationService'.

      It would also be cool if this could be backported to camunda 7.11, 7.12 and 7.13.

        This is the controller panel for Smart Panels app

            [CAM-12228] Create modifier for ProcessEngineConfigurationImpl.authorizationService

            Tassilo Weidner added a comment -

            Hi fml2,

            Thanks for reaching out to us with your feature request.

            Unfortunately, only bugs can be backported, and patch releases are exclusively available for enterprise customers. If you are an enterprise customer, you could create a support case.

            What about creating a subclass of ProcessEngineConfigurationImpl and adding the setter to this subclass?

            Best,
            Tassilo

            Tassilo Weidner added a comment - Hi fml2 , Thanks for reaching out to us with your feature request. Unfortunately, only bugs can be backported, and patch releases are exclusively available for enterprise customers. If you are an enterprise customer, you could create a support case. What about creating a subclass of ProcessEngineConfigurationImpl and adding the setter to this subclass? Best, Tassilo

            fml2 added a comment -

            > What about creating a subclass of ProcessEngineConfigurationImpl and adding the setter to this subclass?

            I could surely do this, but then I'd assign a value to the field in an other object and not the one I want.

            Thank you for the hints about how to proceed in this case.

            fml2 added a comment - > What about creating a subclass of ProcessEngineConfigurationImpl and adding the setter to this subclass? I could surely do this, but then I'd assign a value to the field in an other object and not the one I want. Thank you for the hints about how to proceed in this case.

            Tassilo Weidner added a comment -

            Hi fml2,

            [...] I'd assign a value to the field in an other object and not the one I want.

            I meant that you could bootstrap the engine from your custom subclass.

            Do you want to raise a pull request to add the setter? It could make it into the 7.14 release.

            Best,
            Tassilo

            Tassilo Weidner added a comment - Hi fml2 , [...] I'd assign a value to the field in an other object and not the one I want. I meant that you could bootstrap the engine from your custom subclass. Do you want to raise a pull request to add the setter? It could make it into the 7.14 release. Best, Tassilo

            fml2 added a comment - - edited

            I meant that you could bootstrap the engine from your custom subclass.

            Oh, that would be too complicated. I'm an ordinary user

            Do you want to raise a pull request to add the setter? It could make it into the 7.14 release.

            I'll try, yes. The desire is somewhat weakened by the fact that the reflection based solution works

            fml2 added a comment - - edited I meant that you could bootstrap the engine from your custom subclass. Oh, that would be too complicated. I'm an ordinary user Do you want to raise a pull request to add the setter? It could make it into the 7.14 release. I'll try, yes. The desire is somewhat weakened by the fact that the reflection based solution works

            fml2 added a comment -

            I've created https://github.com/camunda/camunda-bpm-platform/pull/915

            fml2 added a comment - I've created https://github.com/camunda/camunda-bpm-platform/pull/915

            Tassilo Weidner added a comment -

            Hi fml2,

            Thank you for raising the PR. I'll have a look.

            Best,
            Tassilo

            Tassilo Weidner added a comment - Hi fml2 , Thank you for raising the PR. I'll have a look. Best, Tassilo

            Tassilo Weidner added a comment -

            Hi fml2,

            I've merged your contribution with the master branch.

            Thank you!

            Best,
            Tassilo

            Tassilo Weidner added a comment - Hi fml2 , I've merged your contribution with the master branch. Thank you! Best, Tassilo

              tassilo.weidner Tassilo Weidner
              fml2 fml2
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: