Loading...

XML

Word

Printable

Details

Type: Sub-task
Resolution: Fixed
Priority: L3 - Default
Fix Version/s: 7.16.0, 7.16.0-alpha4
Affects Version/s: None
Component/s: quarkus
Labels:
None

Description

AC

Solution ideas are investigated how to mark the DefaultContextAssociationManager$RequestScopedAssociation bean from engine-cdi as an unremovable bean in a more robust way
The best idea is implemented

Hints

Currently, the name of the bean is partially hardcoded:

  @BuildStep
  protected void unremovableBeans(BuildProducer<UnremovableBeanBuildItem> unremovableBeansProducer) {
    unremovableBeansProducer.produce(
        UnremovableBeanBuildItem.beanTypes(
            DotName.createSimple(DefaultContextAssociationManager.class.getName() + "$RequestScopedAssociation")));
  }

Solution idea

Move DefaultContextAssociationManager$RequestScopedAssociation and DefaultContextAssociationManager$ScopedAssociation to dedicated classes. Like this, we can reference the RequestScopedAssociation directly. DefaultContextAssociationManager is private API so we can change the class structure. Creating dedicated classes does not have any impact behaviorally. For consistency reasons, let's also move DefaultContextAssociationManager$ConversationScopedAssociation to a dedicated class.

mgm-controller-panel

This is the controller panel for Smart Panels app

Attachments

Activity

People

Assignee:: Tassilo Weidner

Reporter:: Tassilo Weidner

DRI:: Tassilo Weidner

Reviewer:: Nikola Koevski

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 20/Jul/21 11:42 AM

Updated:: 27/Aug/21 3:03 PM

Resolved:: 29/Jul/21 3:50 PM

CDI: Make marking DefaultContextAssociationManager$RequestScopedAssociation bean as unremovable more robust