Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-1538

OSGi Manifest headers still mention "Activiti"

    • Icon: Bug Report Bug Report
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.1.0, 7.1.0-alpha1
    • None
    • engine
    • None

      This is the controller panel for Smart Panels app

          [CAM-1538] OSGi Manifest headers still mention "Activiti"

          Removed all occurences of "activiti" from camunda-engine-osgi module and generated MANIFEST.MF s for camunda-engine and camunda-engine-osgi now have correct "org.camunda.*" imports

          https://github.com/camunda/camunda-bpm-platform/pull/47

          Ronny Bräunlich added a comment - Removed all occurences of "activiti" from camunda-engine-osgi module and generated MANIFEST.MF s for camunda-engine and camunda-engine-osgi now have correct "org.camunda.*" imports https://github.com/camunda/camunda-bpm-platform/pull/47

          Hi Ronny,

          I merged your pull request!

          Furthermore, the "engine/pom.xml" contains some additional osgi imports, which are declared as "optional". But this imported packages are not marked as optional in the generated MANIFEST.MF file. Would you like to have a look into it, why is that so?

          Cheers,
          Roman

          Roman Smirnov added a comment - Hi Ronny, I merged your pull request! Furthermore, the "engine/pom.xml" contains some additional osgi imports, which are declared as "optional". But this imported packages are not marked as optional in the generated MANIFEST.MF file. Would you like to have a look into it, why is that so? Cheers, Roman

          Hi Roman,

          thank you!

          Yes, I already investigated the problem and I think that should be another JIRA issue because it would require changes on several modules (from my point of view).
          When you look at the pom.xml in the engine-osgi module you'll find the configuration for the maven-bundle-plugin, which includes all the variables e.g. ${camunda.osgi.export}
          The engine module declares its variables but lacks this configuration.
          I guess the best thing to do would be to move the configuration from the engine-osgi module to the root pom. But right now I am not sure what the consequences would be for the other modules. Seems like I gotta do some research

          Ronny Bräunlich added a comment - Hi Roman, thank you! Yes, I already investigated the problem and I think that should be another JIRA issue because it would require changes on several modules (from my point of view). When you look at the pom.xml in the engine-osgi module you'll find the configuration for the maven-bundle-plugin, which includes all the variables e.g. ${camunda.osgi.export} The engine module declares its variables but lacks this configuration. I guess the best thing to do would be to move the configuration from the engine-osgi module to the root pom. But right now I am not sure what the consequences would be for the other modules. Seems like I gotta do some research

          Hi Ronny,

          you are right that should be another JIRA Issue. Therefore I created a new Bug CAM-1551, maybe you can assign it to you (I was not able to do it ).

          Cheers,
          Roman

          Roman Smirnov added a comment - Hi Ronny, you are right that should be another JIRA Issue. Therefore I created a new Bug CAM-1551 , maybe you can assign it to you (I was not able to do it ). Cheers, Roman

            Unassigned Unassigned
            meyer Daniel Meyer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: