Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-1573

Add shaded classes to source jar whenever maven-shade-plugin is used

XMLWordPrintable

      In some places maven-shade-plugin is used, e.g. here: https://github.com/camunda/camunda-bpm-platform-ee/blob/master/distro/ibmWs8/service/pom.xml

      But in the resulting source jar the shaded classes are not contained - so there is a mismatch between classes.jar and sources.jar.

      I think this should be changed. Not completly sure - but it should be doable by a shading configurationhttp://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#createSourcesJar

      e.g.:

      <plugin>
      <groupId>org.apache.maven.plugins</groupId>
      <artifactId>maven-shade-plugin</artifactId>
      <configuration>
      <createSourcesJar>true</createSourcesJar>
      </configuration>
      </plugin>

        This is the controller panel for Smart Panels app

            [CAM-1573] Add shaded classes to source jar whenever maven-shade-plugin is used

            Christian added a comment -

            Hint:

            There is a bug in maven-shade plugin. It requires generated -sources.jar from current module, otherwise the current modules sources won't be included in the shaded sources jar.

            Correct usage as of maven shade version 2.2 and earlier

            <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-source-plugin</artifactId>
            <executions>
            <execution>
            <id>generate-sources-for-shade-plugin</id>
            <phase>package</phase>
            <goals>
            <goal>jar-no-fork</goal>
            </goals>
            </execution>
            </executions>
            </plugin>
            <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-shade-plugin</artifactId>
            <configuration>
            <createSourcesJar>true</createSourcesJar>
            </configuration>
            </plugin

            Christian added a comment - Hint: There is a bug in maven-shade plugin. It requires generated -sources.jar from current module, otherwise the current modules sources won't be included in the shaded sources jar. Correct usage as of maven shade version 2.2 and earlier <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-source-plugin</artifactId> <executions> <execution> <id>generate-sources-for-shade-plugin</id> <phase>package</phase> <goals> <goal>jar-no-fork</goal> </goals> </execution> </executions> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-shade-plugin</artifactId> <configuration> <createSourcesJar>true</createSourcesJar> </configuration> </plugin

              lipphardt Christian
              ruecker Bernd Ruecker
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: