Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-3170

Manual activation rules cannot be used for plan items

    XMLWordPrintable

Details

    Description

      Three problems:
      1. For a plan item, creating a child element of type "PlanItemControl" results in an xml element <planItemControl>; This is not valid CMMN xml, should be <itemControl>
      2. <defaultControl> elements are only allowed for Plan Item Definitions. For Plan Items, it should only be possible to set an <itemControl> element. Due to our class structure, it is possible to create a <defaultControl> element for a plan item, which is not allowed according to the CMMN xsd.
      3. Accordingly, the engine is not able to parse a CMMN file with a <planItemControl> element because it validates by the CMMN xsd and ignores a manual activation rule that is correctly configure with <itemControl>

      Reason:
      The class structure for PlanItemControl elements is not entirely correct:

      Current state:

      PlanItemControl <-- PlanItemControlImpl <-- DefaultControl

      PlanItem has a child element that is an instance of PlanItemControl. Accordingly, DefaultControl can be set there.

      Desired state:

      A new class ItemControl that inherits from PlanItemControlImpl and that is used for plan items. Keep in mind that this breaks/corrects the API.
      Engine tests are corrected and re-added to the test suite (confer org.camunda.bpm.engine.test.cmmn.activation.ManualActivationRuleTest and the cmmn element handler tests that currently check for PlanItemControl elements)

      mgm-controller-panel

        This is the controller panel for Smart Panels app

        Attachments

          Issue Links

            Activity

              People

                thorben.lindhauer Thorben Lindhauer
                thorben.lindhauer Thorben Lindhauer
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Salesforce