L3 - Default Description
AT:
- add null checks to all query parameters in cockpit custom queries
Some Cockpit plugins (e.g. Incidents plugin) make custom queries. The SQL queries behind fail when certain invalid query parameters are used resulting in a MyBatis exception. When analyzing such an error, it takes very long to track the problem down to the invalid query parameters. The plugins should assert that the parameters are valid before executing the query.
Example: CAM-4181
Here, the incident query does not allow for a null value in the parameter "activityIdIn". This should be checked when the query is constructed. Then it would be immediately clear that client-side has made an invalid request.
Without this, we had to consider other points of failure (e.g. application server, database) which included setting up a WebLogic/Oracle distro and remote debugging it. This is stressful and takes time.