-
Bug Report
-
Resolution: Fixed
-
L3 - Default
-
None
-
None
The public api returns in same cases internal classes, for example (ConditionExpression is part of the internal api):
https://github.com/camunda/camunda-cmmn-model/blob/master/src/main/java/org/camunda/bpm/model/cmmn/instance/RepetitionRule.java#L31
AT:
- the public api does not return internal classes
Please note: This is a breaking change!
This is the controller panel for Smart Panels app
[CAM-4932] Cmmn model API returns internal classes
roman.smirnov is this related to https://app.camunda.com/jira/browse/CAM-2269?
Hi roman.smirnov,
is https://github.com/camunda/camunda-cmmn-model/blob/master/src/main/java/org/camunda/bpm/model/cmmn/impl/instance/CaseFileItemTransitionStandardEvent.java
intentionally still an impl class without interface? It isn't actually exposed by the API but maybe it would be got to be consistent on this?
Cheers,
Sebastian
Hi sebastian.menski,
Yes, it was my intention to keep the classes CaseFileItemTransitionStandardEvent and PlanItemTransitionStandardEvent as impl classes without an interface.
I agree with you that we should be consistent and expose them by the API. But I would suggest to bring both classes together, because if you have for example the following situation:
<sentry>
<planItemOnPart>
<standardEvent>complete</standardEvent>
</planItemOnPart>
<caseFileItemOnPart>
<standardEvent>update</standardEvent>
</caseFileItemOnPart>
</sentry>
and if you execute the following line of code:
Collection<CaseFileItemTransitionStandardEvent> events = modelInstance.getModelElementsByType(CaseFileItemTransitionStandardEvent.class);
then you get both standard events independent from the fact that the first standard event is a PlanItemTransitionStandardEvent and the second is a CaseFileItemTransitionStandardEvent.
So I would introduce a new interface named StandardEvent and a impl class StandardEventImpl, and the classes PlanItemTransitionStandardEvent and CaseFileItemTransitionStandardEvent will be deleted.
What do you think? Feel free to reopen this issue, I will take care of it.
Cheers,
Roman
See commits: