Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-5695

DMN table style refresh

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.5.0, 7.5.0-alpha4
    • None
    • dmn-ui
    • None

      Add BPMN.io issue to simplify and improve visual of table

      Ideas:

      • make less green
      • ony show drag handlers on hover
      • put logo atop of table
      • bring down the general noise

        This is the controller panel for Smart Panels app

            [CAM-5695] DMN table style refresh

            Valentin added a comment -

            additional commits:

            Hope you'll like it

            Valentin added a comment - additional commits: https://github.com/bpmn-io/dmn-js/commit/bfbc8ade0f03a56d60573ae534f3fd524d7ee835 https://github.com/bpmn-io/table-js/commit/14909e288f7cb498e4ba5494d5f4e7cd79a582fa Hope you'll like it

            Sebastian Stamm added a comment -

            Code looks fine. I am handing this review over to gimbel for the following reason:

            • the code rendering the bpmn.io logo as well as the license source code comment has been moved from dmn-js to table-js: https://github.com/bpmn-io/table-js/blob/master/lib/core/Sheet.js#L183-L192
            • table-js is currently licensed under MIT; only dmn-js is licensed under the bpmn.io license. Do we have to change anything?
            • Context Info: bpmn-js is licensed under bpmn.io; diagram-js is licensed under MIT

            Sebastian Stamm added a comment - Code looks fine. I am handing this review over to gimbel for the following reason: the code rendering the bpmn.io logo as well as the license source code comment has been moved from dmn-js to table-js: https://github.com/bpmn-io/table-js/blob/master/lib/core/Sheet.js#L183-L192 table-js is currently licensed under MIT; only dmn-js is licensed under the bpmn.io license. Do we have to change anything? Context Info: bpmn-js is licensed under bpmn.io; diagram-js is licensed under MIT

            Robert Gimbel added a comment -

            Yes, that is a problem. We should talk about that.

            Robert Gimbel added a comment - Yes, that is a problem. We should talk about that.

            Sebastian Stamm added a comment -

            The code rendering the bpmn.io logo must be in dmn-js. This has to be fixed before we can release a new version of table-js or dmn-js.

            Sebastian Stamm added a comment - The code rendering the bpmn.io logo must be in dmn-js. This has to be fixed before we can release a new version of table-js or dmn-js.

            Valentin added a comment -

            I moved the logo / license / thing back in dmn-js

            Valentin added a comment - I moved the logo / license / thing back in dmn-js

              michael.schoettes Michael Schoettes
              valentin.vago Valentin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: