Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6203

Configure Tx Isolation level READ_COMMITTED in engine-IT on Wildfly

      • READ_COMMITTED is configured as default transaction isolation level on each datasource in wildfly

        This is the controller panel for Smart Panels app

            [CAM-6203] Configure Tx Isolation level READ_COMMITTED in engine-IT on Wildfly

            Christian added a comment - - edited

            I created an engine-it test to check for the correct transaction isolation level some days ago.
            See https://github.com/camunda/camunda-bpm-platform/commit/46510daf0cb60b4f52755aa135e017d1867ee7dc

            Christian added a comment - - edited I created an engine-it test to check for the correct transaction isolation level some days ago. See https://github.com/camunda/camunda-bpm-platform/commit/46510daf0cb60b4f52755aa135e017d1867ee7dc

            Askar added a comment -

            I don't get this ticket, READ_COMMITTED is a default transaction isolation level on H2 http://www.h2database.com/html/advanced.html
            and following datasources have READ_COMMITTED hardcoded in the config on wildfly.

            mariadb-ds.xml
            mariadb-xa-ds.xml
            mysql-ds.xml
            mysql-xa-ds.xml
            oracle-ds.xml
            postgresql-ds.xml
            postgresql-xa-ds.xml
            

            should I add corresponding configuration to other datasources where it's missing? All servers or Wildfly only? body of ticket is contradicting to the title

            Askar added a comment - I don't get this ticket, READ_COMMITTED is a default transaction isolation level on H2 http://www.h2database.com/html/advanced.html and following datasources have READ_COMMITTED hardcoded in the config on wildfly. mariadb-ds.xml mariadb-xa-ds.xml mysql-ds.xml mysql-xa-ds.xml oracle-ds.xml postgresql-ds.xml postgresql-xa-ds.xml should I add corresponding configuration to other datasources where it's missing? All servers or Wildfly only? body of ticket is contradicting to the title

            As discussed:

            • in the context of this issue, lets add READ_COMMITTED to all the datasources (DB2 ...)
            • lets create additional issues for the other servers
            • Christian's test can be added when it is done for all servers

            Daniel Meyer added a comment - As discussed: in the context of this issue, lets add READ_COMMITTED to all the datasources (DB2 ...) lets create additional issues for the other servers Christian's test can be added when it is done for all servers

            Daniel Meyer added a comment -

            I think we should remove the READ COMMITTED test (at least on WLS and WAS) because otherwise the CI will be red until CAM-6460 and CAM-6461 are fixed.

            askar.akhmerov can you take care of this?

            Daniel Meyer added a comment - I think we should remove the READ COMMITTED test (at least on WLS and WAS) because otherwise the CI will be red until CAM-6460 and CAM-6461 are fixed. askar.akhmerov can you take care of this?

            Christian added a comment -

            WLS is the only one affected. WAS was another issue, Askar already took care of it.

            Christian added a comment - WLS is the only one affected. WAS was another issue, Askar already took care of it.

            Sebastian Menski added a comment - - edited

            Review hints:

            Sebastian Menski added a comment - - edited Review hints: the test case TransactionIsolationLevelTest is missing on all branches except for master also please remove the println statement: https://github.com/camunda/camunda-bpm-platform-maintenance/blob/c88c284c1d90bf91d451185fb47e02768d3a3db6/qa/integration-tests-engine/src/test/java/org/camunda/bpm/integrationtest/functional/transactions/TransactionIsolationLevelTest.java#L43 why is the transaction level not set on h2? I think it should be consistent for all databases. can we please talk about merging branches without introducing a merge commits, that really isn't nice to review, for example there is now two different commits on master which are the same: 8fa5f7b1 vs 4fc104ad

            Sebastian Menski added a comment - The Isolation Test is broken on 7.2: https://ci.camunda.com/jenkins/7.2/view/All/job/7.2-EE-engine-IT-jbosseap-62-postgresql-93/lastCompletedBuild/testReport/

            Sebastian Menski added a comment - Isolation Test also broken on 7.5: https://ci.camunda.com/jenkins/7.5/job/7.5-engine-IT-wildfly-100-h2/lastCompletedBuild/testReport/org.camunda.bpm.integrationtest.functional.transactions/TransactionIsolationLevelTest/testTransactionIsolationLevelOnConnection/

            Sebastian Menski added a comment - And 7.3 https://ci.camunda.com/jenkins/7.3/job/7.3-engine-IT-jboss-72-h2/lastCompletedBuild/testReport/org.camunda.bpm.integrationtest.functional.transactions/TransactionIsolationLevelTest/testTransactionIsolationLevelOnConnection/

            Sebastian Menski added a comment - And 7.4: https://ci.camunda.com/jenkins/7.4/job/7.4-engine-IT-wildfly-82-h2/lastCompletedBuild/testReport/org.camunda.bpm.integrationtest.functional.transactions/TransactionIsolationLevelTest/testTransactionIsolationLevelOnConnection/

              sebastian.menski Sebastian Menski
              meyer Daniel Meyer
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: