Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6222

Wrong Tab order for confirm and cancel button for datepickers

XMLWordPrintable

      Reproduce:

      • Open a datepicker with the keyboard
      • Use Tab to navigate out of the time-picker

      Expected:

      • The confirm button is focussed

      Observed:

      • The element after the datepicker is focussed
      • I have to tab through all elements on the page to access the confirm button
      • Alternatively, I can Shift-Tab to reach the confirm and cancel buttons

        This is the controller panel for Smart Panels app

            [CAM-6222] Wrong Tab order for confirm and cancel button for datepickers

            Valentin added a comment -

            The new positioning of the buttons (below the datepicker) breaks the unity/alignment of the design, every other data types have their controls on the top-right corner of the field.

            I was surprise because didn't saw the confirm/cancel buttons right away (I was really expecting them to be at the same place like for the other inline-fields).

            It is technically not a problem to position them above the "input" and it does not break the keyboard navigation.

            gimbel is there an other argument against putting the buttons back at the same place as the were (and keep the alignment)?

            Valentin added a comment - The new positioning of the buttons (below the datepicker) breaks the unity/alignment of the design, every other data types have their controls on the top-right corner of the field. I was surprise because didn't saw the confirm/cancel buttons right away (I was really expecting them to be at the same place like for the other inline-fields). It is technically not a problem to position them above the "input" and it does not break the keyboard navigation. gimbel is there an other argument against putting the buttons back at the same place as the were (and keep the alignment)?

            Robert Gimbel added a comment -

            can we have a poll on this one, because personally I finde the very oposite intuitive

            Robert Gimbel added a comment - can we have a poll on this one, because personally I finde the very oposite intuitive

            Valentin added a comment -

            Sure!

            https://forum.camunda.org/t/poll-where-should-be-the-confirm-cancel-buttons/1014

            Depending on the result I would also move the buttons of the other inline fields (for consistency).

            Valentin added a comment - Sure! https://forum.camunda.org/t/poll-where-should-be-the-confirm-cancel-buttons/1014 Depending on the result I would also move the buttons of the other inline fields (for consistency).

            Robert Gimbel added a comment -

            Let's see. I do not see the other fields as a logical consequence.

            Robert Gimbel added a comment - Let's see. I do not see the other fields as a logical consequence.

            Valentin added a comment -

            I slightly changed the position of the controls to have them on the datepicker (bottom-right corner)

            Valentin added a comment - I slightly changed the position of the controls to have them on the datepicker (bottom-right corner)

            Valentin added a comment -

            Please, just have a quick look at the minimal changes I did.

            Valentin added a comment - Please, just have a quick look at the minimal changes I did.

            Sebastian Stamm added a comment -

            Changes should be backported to 7.5

            Sebastian Stamm added a comment - Changes should be backported to 7.5

            Valentin added a comment -

            The little positioning changes have been backported.

            Valentin added a comment - The little positioning changes have been backported.

              michael.schoettes Michael Schoettes
              sebastian.stamm Sebastian Stamm
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: