Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-6223

Modals do not trap keyboard focus

XMLWordPrintable

      Reproduce:

      • Open a modal dialog
      • Press Tab repeatedly

      Expected:

      • I cannot leave the modal dialog with tab without closing it first

      Observed:

      • I can access all elements of the page without closing the modal dialog

        This is the controller panel for Smart Panels app

            [CAM-6223] Modals do not trap keyboard focus

            Sebastian Stamm added a comment -

            Unfortunately, we cannot upgrade the angular bootstrap ui library without also upgrading the angular.js version, but we need a bugfix from a later angular bootstrap ui version, so this commit manually merges the changes from https://github.com/angular-ui/bootstrap/commit/a028d2aa163e5dd1c50ba634bcc9e84d716c368e into the forked ui bootstrap version.

            Perspectively, we should update angular.js and angular ui bootstrap.

            Sebastian Stamm added a comment - Unfortunately, we cannot upgrade the angular bootstrap ui library without also upgrading the angular.js version, but we need a bugfix from a later angular bootstrap ui version, so this commit manually merges the changes from https://github.com/angular-ui/bootstrap/commit/a028d2aa163e5dd1c50ba634bcc9e84d716c368e into the forked ui bootstrap version. Perspectively, we should update angular.js and angular ui bootstrap.

            Valentin added a comment -

            for upgrading Angular.js, ideally, at least, to the last 1.3.x so we are a bit "future proof" and take advantage of production setup as explained here:
            https://code.angularjs.org/1.3.20/docs/guide/production
            (from that article: https://medium.com/swlh/improving-angular-performance-with-1-line-of-code-a1fb814a6476#.p3fdj5ojv)

            Valentin added a comment - for upgrading Angular.js, ideally, at least, to the last 1.3.x so we are a bit "future proof" and take advantage of production setup as explained here: https://code.angularjs.org/1.3.20/docs/guide/production (from that article: https://medium.com/swlh/improving-angular-performance-with-1-line-of-code-a1fb814a6476#.p3fdj5ojv )

              michael.schoettes Michael Schoettes
              sebastian.stamm Sebastian Stamm
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: