Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-7153

Review of changes made in CAM-7042

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: L3 - Default
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.7.0, 7.7.0-alpha1
    • Component/s: engine
    • Labels:
      None

      Description

      Hi Askar Akhmerov, I reviewed both CAM-7041 and the changes of CAM-7042. I suggest we have a chat about this and discuss the points below.

      General

      Build:

      CAM-7042

      Code
      • Can we get rid of MybatisJoinHelper#orderBy (the deprecated method)? It is only there for the webapp, and yet, the webapp did not support multiple orderings until now. Thus, I think it is only needed for the default ordering. If true, I would simply move the default ordering String into AbstractRestQueryParametersDto.
      • Mybatis-Jboss/Wildfly-Modules: Why is there a dependency to camunda-engine? Can we remove that?
      • You replaced an exception in AbstractRestQueryParameterDto#getOrderBy by a default value. Is there a specific reason for that? If not, I suggest we keep the exception.
      Docs

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              thorben.lindhauer Thorben Lindhauer
              Reporter:
              thorben.lindhauer Thorben Lindhauer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: