-
Type:
Task
-
Resolution: Fixed
-
Priority:
L3 - Default
-
Affects Version/s: None
-
Component/s: engine
-
None
Hi askar.akhmerov, I reviewed both CAM-7041 and the changes of CAM-7042. I suggest we have a chat about this and discuss the points below.
General
Build:
- This would have saved the chaos on the master: https://github.com/camunda/camunda-bpm-platform/wiki/Test-your-branch-against-our-supported-databases. I'm sorry I didn't remember this myself, but perhaps we will in the future
CAM-7042
Code
- Can we get rid of MybatisJoinHelper#orderBy (the deprecated method)? It is only there for the webapp, and yet, the webapp did not support multiple orderings until now. Thus, I think it is only needed for the default ordering. If true, I would simply move the default ordering String into AbstractRestQueryParametersDto.
- Mybatis-Jboss/Wildfly-Modules: Why is there a dependency to camunda-engine? Can we remove that?
- You replaced an exception in AbstractRestQueryParameterDto#getOrderBy by a default value. Is there a specific reason for that? If not, I suggest we keep the exception.
Docs
This is the controller panel for Smart Panels app
- is related to
-
-
- Closed
-