Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-7497

As cockpit user, I can see incidents in the process definition view

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.8.0, 7.8.0-alpha4
    • None
    • cockpit

      AT:

      • similar to process instance view I can see incidents in the process definition view
      • an additional incidents tab has to implemented
      • incidents tab is available in runtime and history view
      • it is possible to use filter criteria to qualify the search results

        This is the controller panel for Smart Panels app

            [CAM-7497] As cockpit user, I can see incidents in the process definition view

            Seif added a comment -
            • The incidents tab is present in 4 different places, thus there is a new directive that is used to display & control incidents data.
            • As the issue is depending on backend CAM-7820, I will continue the last changes/checks once the backend end point is implemented.

            Seif added a comment - The incidents tab is present in 4 different places, thus there is a new directive that is used to display & control incidents data. As the issue is depending on backend CAM-7820 , I will continue the last changes/checks once the backend end point is implemented.

            Sebastian Stamm added a comment -
            • filter for incidents is missing
            • incident tab in process definition history is missing. The tab is not part of CAM-7820 yet
            • path comment is wrong in ui/cockpit/client/scripts/directives/incidents-tab.html
            • meaning of jd variable name is not clear in ui/cockpit/client/scripts/pages/processDefinition.js Can we find a better name?
            • debug logging left in code: ui/cockpit/client/scripts/pages/processInstance.js
            • Please try to avoid merge commits by using rebase: https://stackoverflow.com/questions/2472254/when-should-i-use-git-pull-rebase/4675513#4675513

            Sebastian Stamm added a comment - filter for incidents is missing incident tab in process definition history is missing. The tab is not part of CAM-7820 yet path comment is wrong in ui/cockpit/client/scripts/directives/incidents-tab.html meaning of jd variable name is not clear in ui/cockpit/client/scripts/pages/processDefinition.js Can we find a better name? debug logging left in code: ui/cockpit/client/scripts/pages/processInstance.js Please try to avoid merge commits by using rebase: https://stackoverflow.com/questions/2472254/when-should-i-use-git-pull-rebase/4675513#4675513

            Seif added a comment -
            • a feature request has been created for the filter component (CAM-8213).

            Seif added a comment - a feature request has been created for the filter component ( CAM-8213 ).

            Sebastian Stamm added a comment -

            I cannot find a commit addressing these issues:

            • path comment is wrong in ui/cockpit/client/scripts/directives/incidents-tab.html
            • meaning of jd variable name is not clear in ui/cockpit/client/scripts/pages/processDefinition.js Can we find a better name?
            • debug logging left in code: ui/cockpit/client/scripts/pages/processInstance.js

            Sebastian Stamm added a comment - I cannot find a commit addressing these issues: path comment is wrong in ui/cockpit/client/scripts/directives/incidents-tab.html meaning of jd variable name is not clear in ui/cockpit/client/scripts/pages/processDefinition.js Can we find a better name? debug logging left in code: ui/cockpit/client/scripts/pages/processInstance.js

            Seif added a comment -

            sebastian.stamm Sorry, I hadn't commit the related changes. They should be there now.

            Seif added a comment - sebastian.stamm Sorry, I hadn't commit the related changes. They should be there now.

            Sebastian Stamm added a comment -

            Looks good. One minor thing: The file location comment now has a different path at the top of the file than at the bottom of the file. But since almost all of these location comments are wrong anyway, I created a ticket to remove them: CAM-8215

            Sebastian Stamm added a comment - Looks good. One minor thing: The file location comment now has a different path at the top of the file than at the bottom of the file. But since almost all of these location comments are wrong anyway, I created a ticket to remove them: CAM-8215

              Unassigned Unassigned
              michael.schoettes Michael Schoettes
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: