Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-7606

Add "most useful process engine configuration"

    • Icon: Feature Request Feature Request
    • Resolution: Won't Fix
    • Icon: L3 - Default L3 - Default
    • None
    • None
    • engine, spring-boot
    • None

      Currently there is the StandaloneProcessEngineConfiguration, which is often thought to be a meaningful configuration. However, it is not. For example it does not set history level to full and uses the IdGenerator, which is not cluster save.
      So we should introduce an own configuration class which really sets meaningful defaults. This then can be used e.g. in the Spring Boot Starter, as with Spring Boot you typically use default configurations unless there are good reasons to change (don't make me think). Might be aligned with the configs we ship in our distributions.

      First step in this topic: Discuss and agree on meaningful default

        This is the controller panel for Smart Panels app

            [CAM-7606] Add "most useful process engine configuration"

            Falko Menge added a comment -

            Obviously, changing the default serialization format would require us to fix Spin to support all Java collections. But I agree, that switching to JSON might be a little too much for now.

            Plugins could be promoted by a good overview list of all available engine plugins as part of docs.camunda.org and/or the Spring Boot Starter.

            Falko Menge added a comment - Obviously, changing the default serialization format would require us to fix Spin to support all Java collections. But I agree, that switching to JSON might be a little too much for now. Plugins could be promoted by a good overview list of all available engine plugins as part of docs.camunda.org and/or the Spring Boot Starter.

            I see isAutoSchemaUpdate=create as default, as this makes it easy to be ready to go.

            So a condensed list is currently

            • FoxFailedJobParseListener, FoxFailedJobCommandFactory (done in Spribng Boot currently via DefaultFailedJobConfiguration)
            • History-Level: full
            • StringUuidGenerator
            • Job Executor Thread Pool
            • isAutoSchemaUpdate=create
            • authorizationEnabled=true

            And important to keep in mind

            • DeploymentAware Job Executor
            • Spin / Connect

            Bernd Ruecker added a comment - I see isAutoSchemaUpdate=create as default, as this makes it easy to be ready to go. So a condensed list is currently FoxFailedJobParseListener, FoxFailedJobCommandFactory (done in Spribng Boot currently via DefaultFailedJobConfiguration) History-Level: full StringUuidGenerator Job Executor Thread Pool isAutoSchemaUpdate=create authorizationEnabled=true And important to keep in mind DeploymentAware Job Executor Spin / Connect

            Falko Menge added a comment -

            ruecker databaseSchemaUpdate=create is not documented and doesn't seem to work either. When I tried it, it complained that the tables already exist.

            Falko Menge added a comment - ruecker databaseSchemaUpdate=create is not documented and doesn't seem to work either. When I tried it, it complained that the tables already exist.

            Falko Menge added a comment -

            Today, I tried databaseSchemaUpdate=create again and it again complained:

            ENGINE-03015 Problem during schema operation 'create' with statement 'create table ACT_HI_PROCINST (...).

            Cause: 'Table "ACT_HI_PROCINST" already exists

            ...

            ENGINE-08049 Camunda BPM platform stopped at 'Apache Tomcat/8.0.45'

            I'm not sure if this is a bug or a feature, but I would definitely not recommend it as a default in its current state.

            Falko Menge added a comment - Today, I tried databaseSchemaUpdate=create again and it again complained: ENGINE-03015 Problem during schema operation 'create' with statement 'create table ACT_HI_PROCINST (...). Cause: 'Table "ACT_HI_PROCINST" already exists ... ENGINE-08049 Camunda BPM platform stopped at 'Apache Tomcat/8.0.45' I'm not sure if this is a bug or a feature, but I would definitely not recommend it as a default in its current state.

            Falko Menge added a comment -

            I created a documentation pull request, in which I described what I believe is the actual behavior of the engine: https://github.com/camunda/camunda-docs-manual/pull/139

            If that is true and not considered a bug, the default should be databaseSchemaUpdate=true.

            Falko Menge added a comment - I created a documentation pull request, in which I described what I believe is the actual behavior of the engine: https://github.com/camunda/camunda-docs-manual/pull/139 If that is true and not considered a bug, the default should be databaseSchemaUpdate=true.

            Hi ruecker,
            hi menge,

            is the discussion still going on here?
            If we want this to be implemented, I would ask you to finalize the list of changes (ideally put them in description of the ticket). Are you OK with this?

            Thank you

            Svetlana Dorokhova added a comment - Hi ruecker , hi menge , is the discussion still going on here? If we want this to be implemented, I would ask you to finalize the list of changes (ideally put them in description of the ticket). Are you OK with this? Thank you

            Hi Svetlana. I am a bit busy this week but try to come back to try out the new alpha asap and give you feedback anyway. Thanks for the ping

            Bernd Ruecker added a comment - Hi Svetlana. I am a bit busy this week but try to come back to try out the new alpha asap and give you feedback anyway. Thanks for the ping

            Bernd Ruecker added a comment - - edited

            Hi Svetlana.

            Sorry for the delay! We could discuss this again today and the list from above should be the most important things we could recall, so it would be a good idea to start with:

            • FoxFailedJobParseListener, FoxFailedJobCommandFactory (done in Spribng Boot currently via DefaultFailedJobConfiguration)
            • History-Level: full
            • StringUuidGenerator
            • Job Executor Thread Pool
            • isAutoSchemaUpdate=create
            • authorizationEnabled=true

            And important to keep in mind

            • DeploymentAware Job Executor
            • Spin / Connect

            I think this is respected in Spring Boot - but it would be also awesome to have something in "the normal" world (SpringProcessEngineConfiguration & DefaultProcessEngineConfiguration). Do you think this is feasible and how?

            Bernd Ruecker added a comment - - edited Hi Svetlana. Sorry for the delay! We could discuss this again today and the list from above should be the most important things we could recall, so it would be a good idea to start with: FoxFailedJobParseListener, FoxFailedJobCommandFactory (done in Spribng Boot currently via DefaultFailedJobConfiguration) History-Level: full StringUuidGenerator Job Executor Thread Pool isAutoSchemaUpdate=create authorizationEnabled=true And important to keep in mind DeploymentAware Job Executor Spin / Connect I think this is respected in Spring Boot - but it would be also awesome to have something in "the normal" world (SpringProcessEngineConfiguration & DefaultProcessEngineConfiguration). Do you think this is feasible and how?

            Falko Menge added a comment -

            As per our previous discussions, the default should be databaseSchemaUpdate=true. ('create' doesn't exist but it is what 'true' does)

            Falko Menge added a comment - As per our previous discussions, the default should be databaseSchemaUpdate=true . ('create' doesn't exist but it is what 'true' does)

            We are closing this ticket as part of our backlog grooming. Reasons:

            • It is very unlikely that we will implement this

            Thorben Lindhauer added a comment - We are closing this ticket as part of our backlog grooming. Reasons: It is very unlikely that we will implement this

              Unassigned Unassigned
              ruecker Bernd Ruecker
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: