• Type: Feature Request
• Resolution: Fixed
• Priority: L3 - Default
• Fix Version/s: 7.8.0, 7.8.0-alpha4
• Affects Version/s: None
• Component/s: tasklist
• Labels:

  • EasyPick
  • SUPPORT

This is the controller panel for Smart Panels app

[CAM-7846] I can submit form with keyboard shortcut

Collapse comment: Seif added a comment - 04/Sep/17 10:53 AM

Seif added a comment - 04/Sep/17 10:53 AM

Notice:
The shortcut is only trigged from inside any input field in an embedded form to conform to the usual behaviour of form submission shortcuts.
This is different from the behaviour of existing tasklist shortcuts that get triggered from anywhere inside the window except input fields.

Expand comment: Seif added a comment - 04/Sep/17 10:53 AM

Seif added a comment - 04/Sep/17 10:53 AM Notice: The shortcut is only trigged from inside any input field in an embedded form to conform to the usual behaviour of form submission shortcuts. This is different from the behaviour of existing tasklist shortcuts that get triggered from anywhere inside the window except input fields.

Collapse comment: Roman Smirnov added a comment - 05/Sep/17 9:09 AM

Roman Smirnov added a comment - 05/Sep/17 9:09 AM

When hitting ctrl+enter on Chrome/Linux the keyCode is 10 and not 13 (see [1]). We should change

if (e.ctrlKey && e.keyCode === 13) 

to

if (e.ctrlKey && (e.keyCode === 13 || e.keyCode === 10))

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=79407#c2

Expand comment: Roman Smirnov added a comment - 05/Sep/17 9:09 AM

Roman Smirnov added a comment - 05/Sep/17 9:09 AM When hitting ctrl+enter on Chrome/Linux the keyCode is 10 and not 13 (see [1] ). We should change if (e.ctrlKey && e.keyCode === 13) to if (e.ctrlKey && (e.keyCode === 13 || e.keyCode === 10)) [1] : https://bugs.chromium.org/p/chromium/issues/detail?id=79407#c2

Collapse comment: Seif added a comment - 05/Sep/17 10:08 AM

Seif added a comment - 05/Sep/17 10:08 AM

smirnov Nice catch.

Expand comment: Seif added a comment - 05/Sep/17 10:08 AM

Seif added a comment - 05/Sep/17 10:08 AM smirnov Nice catch.