Uploaded image for project: 'camunda BPM'
  1. camunda BPM
  2. CAM-9975

Delete runtime instance batch succeeds if instances are already deleted

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 7.11.0, 7.11.0-alpha4
    • None
    • engine
    • None

      • new API in runtime service to delete running instances if they exist
      • used by batch handler

        This is the controller panel for Smart Panels app

            [CAM-9975] Delete runtime instance batch succeeds if instances are already deleted

            Nikola Koevski added a comment -

            Review hint:

            Nikola Koevski added a comment - Review hint: We should still assert that the correct Exception Message is thrown when the failIfNotExists flag is true here: https://github.com/camunda/camunda-bpm-platform/blob/c1238e652b2ddbbff175d9e7f3c48c3c26c52bdb/engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/RuntimeServiceAsyncOperationsTest.java#L176-L196

            Nikola Koevski added a comment -

            Review hints:

            According to the decisions made, async deletions shouldn't fail if a process instance is not found. Because of this, the failIfNotExists flags should be set to false here:

            To ensure that this is reported by the tests, we can assert that there is no exception in the test here: https://github.com/camunda/camunda-bpm-platform/blob/00793fa18dca29e30227eb6f8d8432a56bb65967/engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/RuntimeServiceAsyncOperationsTest.java#L176-L197

            Nikola Koevski added a comment - Review hints: According to the decisions made, async deletions shouldn't fail if a process instance is not found. Because of this, the failIfNotExists flags should be set to false here: https://github.com/camunda/camunda-bpm-platform/blob/00793fa18dca29e30227eb6f8d8432a56bb65967/engine/src/main/java/org/camunda/bpm/engine/impl/cmd/batch/DeleteProcessInstanceBatchCmd.java#L105 . https://github.com/camunda/camunda-bpm-platform/blob/00793fa18dca29e30227eb6f8d8432a56bb65967/engine/src/main/java/org/camunda/bpm/engine/impl/cmd/batch/DeleteHistoricProcessInstancesBatchCmd.java#L126 To ensure that this is reported by the tests, we can assert that there is no exception in the test here: https://github.com/camunda/camunda-bpm-platform/blob/00793fa18dca29e30227eb6f8d8432a56bb65967/engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/RuntimeServiceAsyncOperationsTest.java#L176-L197

            Miklas Boskamp added a comment -

            Decision: We don't need the ifExists flag on batch jobs. A batch job should always succeed if its goal is already met. Otherwise, this leads to a failed batch which cannot be handled further. So we should strive to produce as less failing batches as possible.
            As a result, the following actions were performed:

            • The ´*ifExists` methods for batches were removed
            • Test cases that cover the `*ifExists` methods for batches were removed

            Miklas Boskamp added a comment - Decision: We don't need the ifExists flag on batch jobs. A batch job should always succeed if its goal is already met. Otherwise, this leads to a failed batch which cannot be handled further. So we should strive to produce as less failing batches as possible. As a result, the following actions were performed: The ´*ifExists` methods for batches were removed Test cases that cover the `*ifExists` methods for batches were removed

              Unassigned Unassigned
              thorben.lindhauer Thorben Lindhauer
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: