Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1400 I can combine reports
  3. OPT-1402

Create an empty combined report

XMLWordPrintable

    • Icon: Feature Part Feature Part
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 2.2.0
    • None
    • frontend
    • None

      AT:

      • evaluating reports still works with the added data structures
      • There is a button in the report list to add a combined report
      • when clicked you jump to the combined report edit mode
      • I can only adjust report name, save and cancel the report
      • When the report saved, it is shown in the report list
      • When I save I go to empty combined report view mode
      • cancel still saves the combined report with the default report name
      • in the view mode I can delete, share and edit the combined report
      • In the report list, I can see the report is a combined report or a single report

        This is the controller panel for Smart Panels app

            [OPT-1402] Create an empty combined report

            Johannes added a comment -

            Review hints:

            • Reports/service.js (small thing): rename type to reportType, so it becomes more clear what kind of type it is, since we use the type field quite often for different kind of porposes.
            • EntityList.js: this component starts to smell, e.g. the render method is 150 lines of code long. We should definitely refactor this component. Let's create a ticket for that.
            • EntityList.ja: the combined report button should have a green color as well, since this color should indicate that this is an action that creates something (according to Franz).
            • ReportView.js: something is wrong with applying the flow node names. When I select a raw data report for any process definition and then I change the view to count frequency of flow nodes, the report builder breaks.
            • ReportView.js the renderReport method is getting very long. Also it is now doing several things at once. I would suggest to refactor the method such that it calls to methods renderSingleReport and renderCombinedReport. There it also immediately becomes clear why we are using this

            Other then that, well done

            Johannes added a comment - Review hints: Reports/service.js (small thing): rename type to reportType, so it becomes more clear what kind of type it is, since we use the type field quite often for different kind of porposes. EntityList.js: this component starts to smell, e.g. the render method is 150 lines of code long. We should definitely refactor this component. Let's create a ticket for that. EntityList.ja: the combined report button should have a green color as well, since this color should indicate that this is an action that creates something (according to Franz). ReportView.js: something is wrong with applying the flow node names. When I select a raw data report for any process definition and then I change the view to count frequency of flow nodes, the report builder breaks. ReportView.js the renderReport method is getting very long. Also it is now doing several things at once. I would suggest to refactor the method such that it calls to methods renderSingleReport and renderCombinedReport. There it also immediately becomes clear why we are using this Other then that, well done

            Omran Abazeed added a comment -

            Created a ticket for point 2: OPT-1420

            Omran Abazeed added a comment - Created a ticket for point 2: OPT-1420

              Unassigned Unassigned
              omran.abazeed Omran Abazeed
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: