Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-1400 I can combine reports
  3. OPT-1449

add combined report label and icon to EntityList items

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: L3 - Default L3 - Default
    • 2.2.0
    • None
    • frontend
    • None

      AT:

      • add the combined report svg icons to the EntityList component
      • add a label that says 'Combined Report'

      Please have a look at these zipline links for reference:
      https://zpl.io/VODNLRr
      https://zpl.io/2pB9DM8

        This is the controller panel for Smart Panels app

            [OPT-1449] add combined report label and icon to EntityList items

            Omran Abazeed added a comment -

            If you have better ideas on how to do things in the commit, please let me know

            Omran Abazeed added a comment - If you have better ideas on how to do things in the commit, please let me know

            Sebastian Stamm added a comment -
            • The font weight of the badge should be normal, not lighter
            • I would rename the function isNotEmptyCombined to isValidCombinedReport. In general I recommend to avoid having negations in function names
            • The getReportVis function should be in the EntityItem component, the EntityList does not need this function
            • Regarding the structure of the /entityIcons/index.js file: Instead of having more top level report icons, I would integrate them into the existing structure, e.g. icons.report.bar.Combined (or .CombinedComponent), instead of icons.report['bar-combined'].Component The "Combined" prefix for the label should be done procedurally in the EntityItem component, not here. That also prevents copy-paste errors like for the combined table label
            • when searching for reports or dashboard, the name of the entity is now broken. The single pieces are displayed as badges

            Sebastian Stamm added a comment - The font weight of the badge should be normal, not lighter I would rename the function isNotEmptyCombined to isValidCombinedReport . In general I recommend to avoid having negations in function names The getReportVis function should be in the EntityItem component, the EntityList does not need this function Regarding the structure of the /entityIcons/index.js file: Instead of having more top level report icons, I would integrate them into the existing structure, e.g. icons.report.bar.Combined (or .CombinedComponent ), instead of icons.report['bar-combined'].Component The "Combined" prefix for the label should be done procedurally in the EntityItem component, not here. That also prevents copy-paste errors like for the combined table label when searching for reports or dashboard, the name of the entity is now broken. The single pieces are displayed as badges

              Unassigned Unassigned
              omran.abazeed Omran Abazeed
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: