Details
-
Task
-
Resolution: Unresolved
-
L3 - Default
-
None
-
None
-
S
Description
Context:
While removing backend limiting with OPT-4760, we noticed that only one of the 13 `evaluateReportForMoreThanTenEvents` IT fails if the `.size(configurationService.getEsAggregationBucketLimit())` part of the respective aggregations (in the GroupBy/DistribtedBy parts) is removed, when in fact they should all fail. This is because the tests misunderstand the premise and just create a definition with >10 instances instead of a definition with >10 flownodes.
Note:
Example of correct test: FlowNodeFrequencyByFlowNodeReportEvaluationIT.evaluateReportForMoreThanTenEvents(), this one creates a definition with > 10 flownodes and fails if the `.size(..)` part is removed from ProcessGroupByFlowNode.createAggregation(..)`.
AT:
- All evaluateReportForMoreThanTenEvents IT are fixed to actually test the scenario of a definition with >10 flownodes (so that tests fail if the `.size(..)` parts of the respective aggregations are removed)
- make it clearer what's supposed to be tested - potentially by changing the test name (maybe sth like evaluateDefinitionWithMoreThanTenFlownodes ?), and/or adding a comment as its really not obvious why these tests exist (it exists because the default .size() on an aggregation is 10 so if we don't specify the size to be bigger than 10, we won't get all results back that we need for accurate reports)
mgm-controller-panel
This is the controller panel for Smart Panels app
Attachments
Issue Links
- is related to
-
-
- Open
-
- links to
