-
Task
-
Resolution: Unresolved
-
L3 - Default
-
None
-
None
-
Not defined
Context:
With OPT-4454, we decided to no longer attempt to limit report results to the configured ESBucketAggregationLimit. However, we still need the ".size(..)" part in some aggregations to ensure we return all available buckets. The default "size(..)" is 10, so if we were to not specify a size here any report with > 10 results would be incomplete.
This usage can be misleading, since we do not use the "ESBucketAggregationLimit" in order to limit the result to the bucket limit but rather in order to extend the result size to make sure the result is not limited to just 10.
To avoid confusion we should add constants we can use in this case instead of the "ESBucketAggregationLimit", ie one constant for setting the size of terms aggregations (eg defaultTermsAggregationSize) and one to set the pagesize of composite aggregations (eg compositeAggregationPageSize).
Note that this ticket is related to OPT-4779 because the IT mentioned in OPT-4779 test the presence of the aggreation .size
AT:
- Constants are added to extend the default size for all relevant aggregations (might also be a good idea to add an explanatory comment to these constants about the default size being 10, since imo its otherwise not obvious why we need the .size(..) part)
- These constants are used instead of the ESBucketAggregationLimit
This is the controller panel for Smart Panels app
- is related to
-
-
- Open
-
- links to
