Uploaded image for project: 'Camunda Optimize'
  1. Camunda Optimize
  2. OPT-5442

Adjust ModelElementFilterQueryUtil instanceMatching and to not double nest filters

XMLWordPrintable

    • 3
    • S

      Context:

      See comment in PR description: https://github.com/camunda/camunda-optimize/pull/3732#issue-695066628 

      Now that we have quite a few Flownode viewLevel filters that need instance matching, we should adjust the instance and flownode filter methods in ModelElementFilterQueryUtil to ideally have a very similar structure so it's easier to read. Also, adjust `add..Filter` methods to not "double nest" the filters (see explanation in PR) if possible (though we should make sure to double check if this kind of nesting has a reason).

      AT:

      • ModelElementFilterQueryUtil is easier to read, especially addInstanceFilterForRelevantViewLevelFilters

        This is the controller panel for Smart Panels app

            [OPT-5442] Adjust ModelElementFilterQueryUtil instanceMatching and to not double nest filters

            Helene Waechtler created issue -
            Helene Waechtler made changes -
            Rank New: Ranked lower
            Sebastian Bathke made changes -
            Labels Original: current_release refactoring New: refactoring
            Sebastian Bathke made changes -
            Labels Original: refactoring New: nice_to_have potential_for_next_quarter refactoring
            Sebastian Bathke made changes -
            Effort Original: Not defined [ 11259 ] New: S [ 11254 ]
            Sebastian Bathke made changes -
            Status Original: Open [ 1 ] New: Scheduled [ 10912 ]
            Eric Lundberg made changes -
            PM Priority New: 3
            Joshua Windels made changes -
            Labels Original: nice_to_have potential_for_next_quarter refactoring New: maintenance nice_to_have potential_for_next_quarter refactoring
            Joshua Windels made changes -
            Status Original: Scheduled [ 10912 ] New: Open [ 1 ]
            Joshua Windels made changes -
            Assignee Original: Helene Waechtler [ helene.waechtler ]

              Unassigned Unassigned
              helene.waechtler Helene Waechtler
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: